Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Ask to confirm before env var deletion #3604

Closed
svenefftinge opened this issue Mar 26, 2021 · 0 comments · Fixed by #4051
Closed

[dashboard] Ask to confirm before env var deletion #3604

svenefftinge opened this issue Mar 26, 2021 · 0 comments · Fixed by #4051
Assignees
@jankeromnes
Labels
component: dashboard priority: 💪 stretch goal This issue is a stretch goal within an iteration. user experience

Comments

@svenefftinge
Copy link
Member

We should ask the user to confirm before deleting an environment variable.
See https://github.com/gitpod-io/gitpod/pull/3581/files#r601636707
@svenefftinge svenefftinge added this to the [backlog] April 2021 milestone Mar 26, 2021
@svenefftinge svenefftinge mentioned this issue Mar 26, 2021
Merged
5 tasks
@jankeromnes jankeromnes added the priority: 💪 stretch goal This issue is a stretch goal within an iteration. label Apr 13, 2021
@jankeromnes jankeromnes self-assigned this Apr 13, 2021
@jankeromnes jankeromnes mentioned this issue Apr 15, 2021
Merged
jankeromnes added a commit that referenced this issue Apr 23, 2021
@jankeromnes
[dashboard] Ask user for confirmation before deleting an environment …
07b1ddd 
…variable + validate duplicate name and scope

Fixes #3604
Fixes #3942
@jankeromnes jankeromnes mentioned this issue Apr 23, 2021
Merged
jankeromnes added a commit that referenced this issue Apr 26, 2021
@jankeromnes
[dashboard] Ask user for confirmation before deleting an environment …
76180fd 
…variable + validate duplicate name and scope

Fixes #3604
Fixes #3942
jankeromnes added a commit that referenced this issue Apr 26, 2021
@jankeromnes
[dashboard] Ask user for confirmation before deleting an environment …
2e7cba9 
…variable + validate duplicate name and scope

Fixes #3604
Fixes #3942
MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this issue Aug 9, 2021
@jankeromnes
[dashboard] Ask user for confirmation before deleting an environment …
df0eda6 
…variable + validate duplicate name and scope

Fixes gitpod-io#3604
Fixes gitpod-io#3942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jankeromnes jankeromnes

Labels
component: dashboard priority: 💪 stretch goal This issue is a stretch goal within an iteration. user experience
Projects
None yet
Milestone
No milestone
3 participants
@gtsiolis @svenefftinge @jankeromnes