Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus ring for <SelectableCardSolid> #17352

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Apr 24, 2023

Description

Adds focus rings to the cards component for improved accessibility.

Related Issue(s)

Split from #17053

Partly addresses #16723

How to test

Go to the preview environment, to user preferences, and Tab your way through to the Theme selection. It should always be clear which one is selected.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@filiptronicek filiptronicek changed the title Add focus ring for <SelectableCardSolid> Add focus ring for <SelectableCardSolid> Apr 24, 2023
@filiptronicek
Copy link
Member Author

Recording 2023-04-24 at 20 32 09

@filiptronicek filiptronicek self-assigned this Apr 24, 2023
@filiptronicek filiptronicek marked this pull request as ready for review April 24, 2023 19:22
@filiptronicek filiptronicek requested a review from a team April 24, 2023 19:22
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 24, 2023
@roboquat roboquat merged commit bc21742 into main Apr 24, 2023
@roboquat roboquat deleted the ft/selectable-cards-focus branch April 24, 2023 20:46
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: accessibility deployed: webapp Meta team change is running in production deployed Change is completely running in production size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants