Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper focus rings #17053

Closed
wants to merge 4 commits into from
Closed

Proper focus rings #17053

wants to merge 4 commits into from

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Mar 27, 2023

Description

Fixes focus and focus rings for the following components:

Related Issue(s)

Fixes #

How to test

Release Notes

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@roboquat
Copy link
Contributor

@filiptronicek: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ft-focus-experiments.1 because the annotations in the pull request description changed
(with .werft/ from main)

@filiptronicek
Copy link
Member Author

filiptronicek commented Mar 28, 2023

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 4543965265

  • recreate_vm: true

@filiptronicek
Copy link
Member Author

filiptronicek commented Mar 29, 2023

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 4556345608

  • recreate_vm: true

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ft-focus-experiments.6 because the annotations in the pull request description changed
(with .werft/ from main)

@stale
Copy link

stale bot commented May 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 8, 2023
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label May 19, 2023
@stale
Copy link

stale bot commented Jun 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 10, 2023
@stale stale bot closed this Jun 17, 2023
@filiptronicek filiptronicek deleted the ft/focus-experiments branch January 24, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants