Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift Org Selector to the right of main menu #16423

Closed
wants to merge 2 commits into from

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Feb 15, 2023

Description

As part of the org nav design updates, this shifts the Organization Selector to the right. It also moves the Admin and Feedback links into the User menu.

image

image

Motivations for moving it are:

  • Avoids having an org icon (and eventually logo) sit so close in proximity to the gitpod logo
  • Allows the main nav links (Workspaces | Projects) to not shift as you change orgs (since org names vary in width)

Related Issue(s)

Fixes #16046

How to test

Release Notes

The organization selector is now located in the top right of the header. Feedback can be accessed from the User menu, also in the top right of the header.

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-bmh-move-org-selector-right.1 because the annotations in the pull request description changed
(with .werft/ from main)

@selfcontained selfcontained marked this pull request as ready for review February 15, 2023 22:27
@selfcontained selfcontained requested a review from a team February 15, 2023 22:27
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 15, 2023
@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 16, 2023

Looking at this now! 👀
Dropped the ball here yesterday—still not feeling great, but will get back to this.

@svenefftinge
Copy link
Member

Are we sure this is better? A reason we moved it left was that that is where our eyes go first thing.

@selfcontained
Copy link
Contributor Author

selfcontained commented Feb 16, 2023

Couple things that feel like an improvement with it on the right:

  • Avoids having an org icon (and eventually logo) sit so close in proximity to the gitpod logo
  • Allows the main nav links (Workspaces | Projects) to not shift as you change orgs (since org names vary in width)
  • Moving the Admin | Feedback links into the User menu seems like an improvement regardless of the org menu moving, this just necessitated the change (but it could be independant).

@geropl
Copy link
Member

geropl commented Feb 21, 2023

I'm a bit out of touch with this change and it's motivation, thus have problems reviewing it. Let me start with dropping my thoughts here:

  • Having both drop-downs on the right is very confusing. Also, I think that "Feedback" is way to hidden (Admin is not important as it's internal only anyway).
  • I feel the biggest clash comes from the icons (Gtipod and org icon). Maybe we can improve that by switching to a color palette that does not include the "Gitpod kumquat orange/yellow!"? 🤷
  • The varying name length is a problem atm. But maybe reserving some static placeholder length is enough?
  • I really like the org selector being close to "Workspaces" and "Projects" this demonstrates the strong connection I feel

@selfcontained
Copy link
Contributor Author

Closing this based on some feedback and other options we'd like to try instead.

@selfcontained selfcontained deleted the bmh/move-org-selector-right branch April 20, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard] Relayout navigation in dashboard
5 participants