-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shift Org Selector to the right of main menu #16423
Conversation
started the job as gitpod-build-bmh-move-org-selector-right.1 because the annotations in the pull request description changed |
|
Are we sure this is better? A reason we moved it left was that that is where our eyes go first thing. |
Couple things that feel like an improvement with it on the right:
|
I'm a bit out of touch with this change and it's motivation, thus have problems reviewing it. Let me start with dropping my thoughts here:
|
Closing this based on some feedback and other options we'd like to try instead. |
Description
As part of the org nav design updates, this shifts the Organization Selector to the right. It also moves the
Admin
andFeedback
links into the User menu.Motivations for moving it are:
Related Issue(s)
Fixes #16046
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh