-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager] allow user custom closed timeout #16278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
started the job as gitpod-build-pd-custom-close-timeout.4 because the annotations in the pull request description changed |
csweichel
reviewed
Feb 8, 2023
iQQBot
force-pushed
the
pd/custom-close-timeout
branch
from
February 9, 2023 10:28
c8e599c
to
f40a338
Compare
iQQBot
changed the title
[ws-manager] custom closed timeout
[ws-manager] allow user custom closed timeout
Feb 9, 2023
WVerlaek
reviewed
Feb 9, 2023
Co-authored-by: Wouter Verlaek <[email protected]>
iQQBot
force-pushed
the
pd/custom-close-timeout
branch
from
February 9, 2023 16:39
4ea516e
to
99515b4
Compare
Contributor
Author
@WVerlaek I addressed your feedback, could you review it again? 🙏 |
Changes lgtm, running some tests now. Do we have/get docs for this as well? |
WVerlaek
approved these changes
Feb 10, 2023
roboquat
added
deployed: workspace
Workspace team change is running in production
deployed
Change is completely running in production
labels
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: workspace
Workspace team change is running in production
deployed
Change is completely running in production
release-note-none
size/M
team: workspace
Issue belongs to the Workspace team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces custom closed timeout, which allows users to customize closed timeout in user preference (need discuss only allow opt-out or can set to anytime)
workspace timeout
meansinactive timeout
This is the workspace part, it only contains
workspace timeout
orclosed timeout
, default isworkspace timeout
, so it's compatible with previous call methods, can be deployed separatelyclosed_timeout
inStartWorkspaceSpec
.closed_timeout
set to0
, it means we disabled check closed timeouttimeout
condition -> if workspace in closed status, checkclosed timeout
, if not timeout, continue to checkworkspace timeout
Related Issue(s)
Relate #16089
How to test
gp timeout set 1h
kubectl describe pods ws-{your-workspace-instance-id}
in your step 1 workspace to check pod annotation. it should be like this.Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh