Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the "close timeout" (IDE + editor timeout) to a user preference. #16089

Closed
loujaybee opened this issue Jan 30, 2023 · 5 comments · Fixed by #16278
Closed

Move the "close timeout" (IDE + editor timeout) to a user preference. #16089

loujaybee opened this issue Jan 30, 2023 · 5 comments · Fixed by #16278
Assignees
Labels
component: gp cli feature: timeout meta: stale This issue/PR is stale and will be closed soon team: IDE

Comments

@loujaybee
Copy link
Member

loujaybee commented Jan 30, 2023

Currently, when an editor disconnects from Gitpod, the workspace timeout is then "reset" to 5 minutes. This means that when a user uses the newly implemented gp timeout set command that closing the editor will still close the workspace after 5 minutes. The user should be able to control this editor timeout value, and when extending the workspace timeout should be able to ensure that the workspace will not close, despite the editor closing.

See related comment

Hello and thank you for releasing the timeout extension command and for allowing us to have timeouts of up to 1-2 days (possibly more). However, it looks like the <5 minute timeout when closing the browser window still applies, so the utility of timeout extensions is pretty limited at the moment (at least in our case). Is there a way for us to have the timeout honored even when all browser tabs are closed?

See internal conversation.

Related to:

@loujaybee loujaybee changed the title Extending workspace timeout should also apply to IDE + editor timeout Review the "close timeout" (e.g. IDE + editor timeout) and how extending the workspace timeout relates. Jan 31, 2023
@loujaybee loujaybee changed the title Review the "close timeout" (e.g. IDE + editor timeout) and how extending the workspace timeout relates. Move the "close timeout" (IDE + editor timeout) to a user preference. Feb 3, 2023
@loujaybee loujaybee linked a pull request Feb 9, 2023 that will close this issue
15 tasks
@loujaybee loujaybee moved this to In Progress in 🚀 IDE Team Feb 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🚀 IDE Team Feb 10, 2023
@laushinka
Copy link
Contributor

We will revisit on 20 Feb 2023.

@loujaybee
Copy link
Member Author

loujaybee commented Feb 20, 2023

This is marked complete (I think by accident) but the UI is not yet implemented, re-opening.

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 3, 2023

Closing this as it has been resolved in #16503. Cc @iQQBot @loujaybee

@gtsiolis gtsiolis closed this as completed Mar 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🚀 IDE Team Mar 3, 2023
@loujaybee
Copy link
Member Author

loujaybee commented Mar 14, 2023

@gtsiolis ah, there might be some confusion.

This issue is related to the editor timeout, not the inactivity timeout (#9038). Updates to editor timeouts were descoped from the other PR to get the change merged, and follow up with additional changes for the editor timeout.

Will re-open.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 18, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: gp cli feature: timeout meta: stale This issue/PR is stale and will be closed soon team: IDE
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants