-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server, cli] Allow flexible workspace timeouts #15815
Conversation
started the job as gitpod-build-se-allow-flexible-timeouts.1 because the annotations in the pull request description changed |
7fa4b30
to
5ff0ac7
Compare
4096151
to
cce772f
Compare
started the job as gitpod-build-se-allow-flexible-timeouts.5 because the annotations in the pull request description changed |
Tested in preview
It would be better if the response to Suggested interaction
|
8cac780
to
4c1de74
Compare
I've added the suggested changes. |
/hold for review Qs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise looks ok.
4c1de74
to
c79ff26
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold |
Description
Makes setWorkspaceTimout handle arbitrary poistive duration strings, matching the format <\D+[mhd]>, which is compatible with go's time Duration.
Related Issue(s)
Fixes #9038
How to test
gp timeout set 4h
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh