Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gp timeout extend and review timeout defaults #16083

Closed
loujaybee opened this issue Jan 30, 2023 · 5 comments
Closed

Deprecate gp timeout extend and review timeout defaults #16083

loujaybee opened this issue Jan 30, 2023 · 5 comments
Labels
component: gp cli feature: timeout meta: stale This issue/PR is stale and will be closed soon team: IDE type: bug Something isn't working

Comments

@loujaybee
Copy link
Member

loujaybee commented Jan 30, 2023

With the introduction of gp timeout set, and usage based pricing, the gp timeout extend behaves in unexpected and unpredictable ways. When you set a new timeout to, let's say 15 hours, running gp timeout extend now arbitrarily reverts the timeout back to 3 hours. Soft deprecate gp timeout extend (e.g. remove from documentation and CLI to protect backwards compatibility) and instruct users to use gp timeout set 180m as an alternative.

image

@Siddhant-K-code
Copy link
Member

💭 Deprecate gp timeout extend would be more ideal to have less & specific options. We also need to handle these:

  • Command Palette:
    image

  • Bottom Status Bar:
    image

@mbrevoort
Copy link
Contributor

Do we know how often extend is used?

Alternatively, even if we do decide to deprecate, we should at least make extend never reduce the time out. If it's less than three hours, then set it to three hours. If it's more than three hours, then do not update its value.

@Siddhant-K-code
Copy link
Member

Do we know how often extend is used?

Not much. Usage is ~85 times a week.

If it's less than three hours, then set it to three hours. If it's more than three hours, then do not update its value.

💯 That sounds like a good first step. 🙋‍♂️

@loujaybee loujaybee changed the title deprecate gp timeout extend or update to 1hr bump deprecate gp timeout extend Feb 3, 2023
@loujaybee loujaybee changed the title deprecate gp timeout extend deprecate gp timeout extend Feb 3, 2023
@loujaybee loujaybee changed the title deprecate gp timeout extend Deprecate gp timeout extend and review timeout defaults Feb 9, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 17, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
@Siddhant-K-code
Copy link
Member

It is already implemented now -- feature docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: gp cli feature: timeout meta: stale This issue/PR is stale and will be closed soon team: IDE type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants