Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gp timeout commands have inconsistent output UX #16084

Closed
loujaybee opened this issue Jan 30, 2023 · 1 comment
Closed

gp timeout commands have inconsistent output UX #16084

loujaybee opened this issue Jan 30, 2023 · 1 comment
Labels
component: gp cli feature: timeout meta: stale This issue/PR is stale and will be closed soon team: IDE type: bug Something isn't working

Comments

@loujaybee
Copy link
Member

loujaybee commented Jan 30, 2023

We have inconsistent log output

gp timeout show => Workspace timeout is set to 60 minutes.

  • The user has inputted no unit of measurement so default to minutes is okay.
  • Command uses present tense whereas gp timeout show uses past tense

gp timeout extend => Workspace timeout has been extended to three hours.

gp timeout set 10h => Workspace timeout has been set to 600 minutes.

  • Uses past tense whereas gp timeout show uses present tense
  • Unit of measurement passed is in hours, but returned value is in minutes.
  • Requires user to do mental math to figure out whether the response is correct
  • Suggestion: Print output consistent with unit given, e.g. if minutes given, show minutes, if hours, show hours.
  • Suggestion: Keep all outputs printed in minutes, and only accept minutes as inputs + response values.
  • Related: [gitpod-cli] Flexible Workspace Timeout - <n>days is not working #15945

image

@stale
Copy link

stale bot commented May 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 2, 2023
@stale stale bot closed this as completed Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: gp cli feature: timeout meta: stale This issue/PR is stale and will be closed soon team: IDE type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant