Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update License File #15368

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Update License File #15368

merged 3 commits into from
Dec 16, 2022

Conversation

meysholdt
Copy link
Member

@meysholdt meysholdt commented Dec 15, 2022

Description

This change

  • adds the AGPL license under the file name LICENSE.md so that GitHub will nicely show the correct license in the repo meta information.
  • removes the MIT and Enterprise licenses, as they are no longer used.
  • fixes a license header that uses the wrong license.
  • Removes a misleading sentence from README.md

Related info:

Related Issue(s)

Fixes https://gitpod.slack.com/archives/C020VCB0U5A/p1670612777895959

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@csweichel
Copy link
Contributor

Renaming LICENSE.AGPL.md to LICENSE.md renders the license header mood. What's the motivation for renaming it?

@meysholdt
Copy link
Member Author

Renaming LICENSE.AGPL.md to LICENSE.md renders the license header mood. What's the motivation for renaming it?

This change leaves License.AGPL.txt in place and fills it with the text Find the license text in LICENSE.md so that the license headers remain valid.

By storing the license in LICENSE.md rather than License.AGPL.txt we follow GitHub naming conventions and GitHub will render the license name nicely next to the repo instead of just showing View License.

Example for "View License" Example for showing the license name
image image

It would be nice to completely delete License.AGPL.txt but this would require changing all license headers.
Since some license headers still point to a slightly wrong file name (#13955 intended to fix that) I'd rather do one update of file headers than two.

@felladrin
Copy link
Contributor

felladrin commented Dec 16, 2022

ℹ️ It's also possible to keep the current one ("License.txt"), as GitHub would still detect it correctly (as it parses the content). Here, for example, I've used "license.txt" and GitHub detected it correctly.

@roboquat roboquat merged commit 03075ce into main Dec 16, 2022
@roboquat roboquat deleted the me/license branch December 16, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants