Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file names in license headers #13955

Closed
wants to merge 3 commits into from
Closed

Fix file names in license headers #13955

wants to merge 3 commits into from

Conversation

meysholdt
Copy link
Member

@meysholdt meysholdt commented Oct 18, 2022

Description

The license files in our repository are named License.MIT.txt and License.AGPL.txt.
This PR fixes files headers that were using the names License-MIT.txt or License-AGPL.txt.

This PR does not change how Gitpod is licensed.

Related Issue(s)

Fixes # https://gitpod.slack.com/archives/C01KGM9DVRC/p1664535939695139

How to test

This PR does not change code.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@meysholdt meysholdt requested review from a team October 18, 2022 13:22
@github-actions github-actions bot added team: SID team: devx team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Oct 18, 2022
@andrew-farries
Copy link
Contributor

would it result in fewer changes to rename the license files instead?

@meysholdt
Copy link
Member Author

would it result in fewer changes to rename the license files instead?

Certainly :)

With that being said, the reasons for this change are:

  • MIT and AGPL become consistent with License.enterprise.txt. There, we've been using . as a separator since the beginning.
  • I remember some contracts that we signed that reference license files in this repo. It would be nice not to break those references by renaming the license files.

@easyCZ
Copy link
Member

easyCZ commented Oct 26, 2022

Moving to draft as this PR requires a rebase and isn't actionable in the current state. Feel free to move back into review if you believe it should remain in review.

@easyCZ easyCZ marked this pull request as draft October 26, 2022 06:56
@stale
Copy link

stale bot commented Nov 9, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 9, 2022
@stale stale bot closed this Nov 22, 2022
@meysholdt meysholdt mentioned this pull request Dec 16, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon release-note-none size/XXL team: devx team: IDE team: SID team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants