Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extracting ide-service from server (ide-service part) #15118

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Dec 2, 2022

Description

chore: extracting ide-service from server (ide-service part)

Related Issue(s)

Relate #9189

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

Co-authored-by: Anton Kosyakov <[email protected]>
Co-authored-by: Victor Nogueira <[email protected]>
Co-authored-by: Andrea Falzetti <[email protected]>
@iQQBot iQQBot requested review from a team December 2, 2022 09:29
@github-actions github-actions bot added team: IDE team: webapp Issue belongs to the WebApp team labels Dec 2, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pd-9189.2 because the annotations in the pull request description changed
(with .werft/ from main)

@iQQBot iQQBot marked this pull request as draft December 2, 2022 09:30
@iQQBot iQQBot removed the team: webapp Issue belongs to the WebApp team label Dec 2, 2022
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

please double check, remove webapp changes and merge 🚀

@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Dec 2, 2022
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Dec 2, 2022
@iQQBot iQQBot marked this pull request as ready for review December 2, 2022 10:11
@iQQBot iQQBot removed the request for review from a team December 2, 2022 10:12
@iQQBot
Copy link
Contributor Author

iQQBot commented Dec 2, 2022

/unhold

@roboquat roboquat merged commit 93a68d3 into main Dec 2, 2022
@roboquat roboquat deleted the pd/9189 branch December 2, 2022 10:17
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XXL team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants