[Server] Extract IDE config resolution logic to ide-service #15062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-andreafalzetti-extract-ide-service-9189.19 because the annotations in the pull request description changed |
|
/werft run recreate-preview 👍 started the job as gitpod-build-andreafalzetti-extract-ide-service-9189.30 |
4 tasks
iQQBot
force-pushed
the
andreafalzetti/extract-ide-service-9189
branch
from
2d79d59 to
495961f
Compare
akosyakov
force-pushed
the
andreafalzetti/extract-ide-service-9189
branch
from
cebaf02 to
c04d484
Compare
akosyakov
force-pushed
the
andreafalzetti/extract-ide-service-9189
branch
5 times, most recently
from
4effd6d to
39972bd
Compare
andreafalzetti
force-pushed
the
andreafalzetti/extract-ide-service-9189
branch
2 times, most recently
from
4b6a8c1 to
a1b9f30
Compare
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
andreafalzetti
force-pushed
the
andreafalzetti/extract-ide-service-9189
branch
from
a1b9f30 to
d07641d
Compare
akosyakov
reviewed
Dec 5, 2022
4 tasks
Co-authored-by: Pudong Zheng <[email protected]> Co-authored-by: Victor Nogueira <[email protected]> Co-authored-by: Andrea Falzetti <[email protected]>
andreafalzetti
force-pushed
the
andreafalzetti/extract-ide-service-9189
branch
from
d07641d to
12c93c0
Compare
andreafalzetti
changed the title
easyCZ
approved these changes
Dec 7, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to migrate resolution of IDE configuration for each workspace from server to ide-service. It is done by using configcat flag. By default is disabled, but the request to ide-service is done anyway that we could confirm reliability and functional correctness, before we migrate.
IDE service part is already deployed and tested: [1]
Co-Authored between: @akosyakov @iQQBot @felladrin @andreafalzetti
Related Issue(s)
Related to #9189
How to test
Check if the IDE opened is the right version
In the server check if the asser log never appears for the following cases:
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh