Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Disallow removing all Owners from a team #13744

Merged
merged 1 commit into from
Oct 11, 2022
Merged

[server] Disallow removing all Owners from a team #13744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions components/gitpod-db/src/typeorm/team-db-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,18 @@ export class TeamDBImpl implements TeamDB {
throw new ResponseError(ErrorCodes.NOT_FOUND, "A team with this ID could not be found");
}
const membershipRepo = await this.getMembershipRepo();

if (role != "owner") {
const ownerCount = await membershipRepo.count({
teamId,
role: "owner",
deleted: false,
});
if (ownerCount <= 1) {
throw new ResponseError(ErrorCodes.CONFLICT, "Team must retain at least one owner");
}
}

const membership = await membershipRepo.findOne({ teamId, userId, deleted: false });
if (!membership) {
throw new ResponseError(ErrorCodes.NOT_FOUND, "The user is not currently a member of this team");
Expand Down