[server] Disallow removing all Owners from a team #13744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-mp-server-prevent-last-user-role-change.1 because the annotations in the pull request description changed |
jankeromnes
reviewed
Oct 11, 2022
easyCZ
force-pushed
the
mp/server-prevent-last-user-role-change
branch
from
d7e47ff to
942add7
Compare
jankeromnes
reviewed
Oct 11, 2022
easyCZ
force-pushed
the
mp/server-prevent-last-user-role-change
branch
from
942add7 to
9d221cc
Compare
easyCZ
changed the title
|
/werft run 👍 started the job as gitpod-build-mp-server-prevent-last-user-role-change.4 |
|
/werft run 👍 started the job as gitpod-build-mp-server-prevent-last-user-role-change.5 |
jankeromnes
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Tested and works! The error is never shown in the UI (so you think you've successfully set yourself to Member until the next time you visit the page), however I'd say this was a pre-existing issue and can be fixed in follow-up. (The error is successfully shown in the console though.)
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Block changing role on teams of size 1 (or less).
Related Issue(s)
Fixes #11452
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide