-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jb] Update the terminal widget tab when the Gitpod Task title changes #12401
Conversation
...jetbrains/backend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/GitpodTerminalService.kt
Outdated
Show resolved
Hide resolved
...jetbrains/backend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/GitpodTerminalService.kt
Outdated
Show resolved
Hide resolved
42babb4
to
989371b
Compare
989371b
to
757856f
Compare
I tested but prev env often times out when I choose IntelliJ and it even broke.. It's down right now, so I will try with: /werft run with-clean-slate-deployment 👍 started the job as gitpod-build-felladrin-jetbrains-task-should-12126.5 |
Let me confirm if the loadbalancer is still up for this PrevEnv. |
bcc4919
to
ec9fce2
Compare
…minal widget tab when Gitpod Task title changes
ec9fce2
to
0d0259f
Compare
It worked fined when using Spring PetClinic, so I've updated the description suggesting using it. I took the chance to rebase the code on main branch. It's ready for review again. |
...jetbrains/backend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/GitpodTerminalService.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected!
Code LGTM. Nice work @felladrin! 🍪
Description
This PR changes two behaviors in JetBrains IDEs:
Related Issue(s)
How to test
Release Notes
Werft options: