Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jb] Update the terminal widget tab when the Gitpod Task title changes #12401

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Aug 25, 2022

Description

This PR changes two behaviors in JetBrains IDEs:

  • Update the terminal widget tab when the Gitpod Task title changes.
  • Disconnect the terminal widget when Gitpod Task exits.

Related Issue(s)

How to test

  1. Open the Preview Environment of this PR.
  2. Open any JetBrains IDE with some workspace that contains tasks defined in .gitpod.yml (e.g. https://github.com/gitpod-io/spring-petclinic)
  3. Observe the terminal tab titles changing with time (while tasks finish running, or when you start "htop" on them, for example).
  4. Type "exit" in a terminal that is running a Gitpod Task and confirm it shows the message "Remote terminal closed".
    image

Release Notes

Terminal tabs running Gitpod Tasks now have their title updated to reflect what's currently running on it.

Werft options:

  • /werft with-preview

@felladrin felladrin force-pushed the felladrin/jetbrains-task-should-12126 branch from 42babb4 to 989371b Compare August 26, 2022 14:30
@roboquat roboquat added size/L and removed size/M labels Aug 26, 2022
@felladrin felladrin force-pushed the felladrin/jetbrains-task-should-12126 branch from 989371b to 757856f Compare August 26, 2022 14:55
@felladrin felladrin marked this pull request as ready for review August 26, 2022 16:57
@felladrin felladrin requested a review from a team August 26, 2022 16:57
@felladrin felladrin changed the title [jb] Handle the exit of terminals from both sides: Gitpod Supervisor and JetBrains IDE [jb] Update the terminal widget tab when the Gitpod Task title changes, and disconnect the terminal widget when Gitpod Task exits Aug 26, 2022
@felladrin felladrin changed the title [jb] Update the terminal widget tab when the Gitpod Task title changes, and disconnect the terminal widget when Gitpod Task exits [jb] Update the terminal widget tab when the Gitpod Task title changes Aug 26, 2022
@andreafalzetti
Copy link
Contributor

andreafalzetti commented Aug 29, 2022

I tested but prev env often times out when I choose IntelliJ and it even broke.. It's down right now, so I will try with:

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-felladrin-jetbrains-task-should-12126.5
(with .werft/ from main)

@felladrin
Copy link
Contributor Author

Let me confirm if the loadbalancer is still up for this PrevEnv.

@felladrin felladrin marked this pull request as draft August 30, 2022 09:09
@felladrin felladrin force-pushed the felladrin/jetbrains-task-should-12126 branch 2 times, most recently from bcc4919 to ec9fce2 Compare August 30, 2022 09:41
…minal widget tab when Gitpod Task title changes
@felladrin felladrin force-pushed the felladrin/jetbrains-task-should-12126 branch from ec9fce2 to 0d0259f Compare August 30, 2022 09:51
@felladrin
Copy link
Contributor Author

felladrin commented Aug 30, 2022

It worked fined when using Spring PetClinic, so I've updated the description suggesting using it.
image

I took the chance to rebase the code on main branch. It's ready for review again.

@felladrin felladrin marked this pull request as ready for review August 30, 2022 09:52
Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected!

Code LGTM. Nice work @felladrin! 🍪

@roboquat roboquat merged commit 74a9b97 into main Aug 30, 2022
@roboquat roboquat deleted the felladrin/jetbrains-task-should-12126 branch August 30, 2022 15:13
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/L team: IDE
Projects
None yet
4 participants