[JetBrains] Task should be stopped when closing terminal tab

[andreafalzetti]

Is your feature request related to a problem? Please describe

Closing a tab maintains the task alive. It's very confusing when the IDE disconnects temporarly and on-reconnect the tasks which have been closed, are all back.

Related discussions / links

• Exiting terminal from Supervisor closes the widget on IntelliJ
• Closing the widget on IntelliJ exits the terminal on Supervisor
• https://gitpod.slack.com/archives/C01KGM9BH54/p1660144865249169?thread_ts=1660140031.099549&cid=C01KGM9BH54

Describe the behaviour you'd like

When the terminal tab "X" button is clicked, the task is stopped

Describe alternatives you've considered

Additional context

[felladrin]

Currently, there's no way to detect when a terminal is closed from the Thin Client, and there's also no way to programmatically close the terminal widget on the Thin Client.

References: Internal Discussion, Issue on YouTrack.

[felladrin]

It has been fixed on JetBrains IDEs v223 (Current EAP) [1].

It worked like a charm, but now, when we close JetBrains EAP Client (by clicking "X" button in the client window), it also considers that the terminals all terminal widgets were closed on purpose (which, in our case, causes all Gitpod Task Terminals to be terminated).

We now need to try to avoid it from happening. Possibly using AppLifecycleListener.appWillBeClosed [1] to remove this subscription from the widget terminals:

gitpod/components/ide/jetbrains/backend-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/GitpodTerminalService.kt

Lines 271 to 279 in fd4386a

	shellTerminalWidget.addListener(object : TerminalWidgetListener {
	override fun allSessionsClosed(widget: TerminalWidget) {
	terminalServiceFutureStub.shutdown(
	TerminalOuterClass.ShutdownTerminalRequest.newBuilder()
	.setAlias(supervisorTerminal.alias)
	.build()
	)
	}
	})

[felladrin]

The issue on YouTrack has been marked as resolved, and I could notice an improvement:

If we click "X" button in the Connection Window, and then click "Disconnect", it correctly disconnects without closing the terminals.

But if we click "X" button in the JetBrains Client, it behaves differently, and the terminals end up closed.