Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mount flag from --bind to --rbind #11961

Closed
wants to merge 1 commit into from
Closed

Change mount flag from --bind to --rbind #11961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/ws-daemon/pkg/content/initializer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ func RunInitializer(ctx context.Context, destination string, initializer *csapi.
Destination: "/dst",
Source: destination,
Type: "bind",
Options: []string{"bind", "rprivate"},
Options: []string{"rbind", "rprivate"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I don't know if we should change to rbind here.
But I was hoping this could address the issue #11852

@csweichel For this mount point, should we need the rbind instead of bind?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bind here is more then enough, since we should not have any other binds inside destination param that used as source for the bind command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with you @sagor999.

Close this PR first, and if issue #11852 still happens, we could revisit it to see what went wrong.

})

spec.Hostname = "content-init"
Expand Down