Change mount flag from --bind to --rbind #11961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenting
force-pushed
the
jenting/mount-rbind
branch
from
648b34d to
702aca0
Compare
Signed-off-by: JenTing Hsiao <[email protected]>
jenting
force-pushed
the
jenting/mount-rbind
branch
from
702aca0 to
4e82fd1
Compare
jenting
commented
Aug 8, 2022
| @@ -192,7 +192,7 @@ func RunInitializer(ctx context.Context, destination string, initializer *csapi. | |||
| Destination: "/dst", | |||
| Source: destination, | |||
| Type: "bind", | |||
| Options: []string{"bind", "rprivate"}, | |||
| Options: []string{"rbind", "rprivate"}, | |||
There was a problem hiding this comment.
To be honest, I don't know if we should change to rbind here.
But I was hoping this could address the issue #11852
@csweichel For this mount point, should we need the rbind instead of bind?
There was a problem hiding this comment.
I think bind here is more then enough, since we should not have any other binds inside destination param that used as source for the bind command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change mount flag from
--bindto--rbind.Related Issue(s)
Fixes #
How to test
None
Release Notes
Documentation
None
Werft options: