Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the Workspace Start URL the in JetBrains Gateway workspaces list #11523

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Adjust the Workspace Start URL the in JetBrains Gateway workspaces list #11523

merged 1 commit into from
Jul 22, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Jul 21, 2022 •
edited
Loading

Description

Adjust the Workspace Start URL the in JetBrains Gateway workspaces list.
This is now aligned with the URL used in WebApp workspaces list.

It's aligned with the URL used in the workspaces list from Gitpod Dashboard:

gitpod/components/dashboard/src/workspaces/WorkspaceEntry.tsx

Lines 56 to 59 in 05ae248

const startUrl = new GitpodHostUrl(window.location.href).with({
pathname: "/start/",
hash: "#" + ws.id,
});

gitpod/components/dashboard/src/workspaces/WorkspaceEntry.tsx

Lines 66 to 69 in 05ae248

{
title: "Open",
href: startUrl.toString(),
},

Related Issue(s)

Fixes #11284

How to test

  • Follow the instructions from how to test it from a Pull Request.
  • Check if when clicking the "Connect" button from a workspace that is not running opens https://gitpod.io/start/#<WORKSPACE_ID> in the browser.

Release Notes

Fixed the Connect Button on JetBrains Gateway workspaces list to avoid opening an invalid URL in case the workspace was not running.

Documentation

None.

Werft options:

  • /werft with-preview

@felladrin felladrin requested a review from a team July 21, 2022 09:35
@felladrin felladrin self-assigned this Jul 21, 2022
@felladrin felladrin marked this pull request as draft July 21, 2022 09:36
@felladrin felladrin force-pushed the felladrin/connect-button-on-gitpod-11284 branch from 05ae248 to a41eb99 Compare July 21, 2022 10:33
@roboquat roboquat added size/M and removed size/S labels Jul 21, 2022
@felladrin felladrin marked this pull request as ready for review July 21, 2022 10:39
@felladrin
Adjust the Workspace Start URL in JetBrains Gateway workspaces list
bebfb53 
This is now aligned with the URL used in WebApp workspaces list.

Also, instructions about how to test the Gateway Plugin from a PR were are added to the Readme.
@felladrin felladrin force-pushed the felladrin/connect-button-on-gitpod-11284 branch from a41eb99 to bebfb53 Compare July 21, 2022 10:44
andreafalzetti
andreafalzetti approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as advertised 💯

@roboquat roboquat merged commit faa5332 into main Jul 22, 2022
@roboquat roboquat deleted the felladrin/connect-button-on-gitpod-11284 branch July 22, 2022 05:53
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreafalzetti andreafalzetti andreafalzetti approved these changes

Assignees

@felladrin felladrin

Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/M team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Connect" button on Gitpod Workspaces list in JetBrains Gateway points to a URL that may be outdated
3 participants
@felladrin @andreafalzetti @roboquat