Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Connect" button on Gitpod Workspaces list in JetBrains Gateway points to a URL that may be outdated #11284

Closed
felladrin opened this issue Jul 11, 2022 · 3 comments · Fixed by #11523
Assignees
Labels

Comments

@felladrin
Copy link
Contributor

felladrin commented Jul 11, 2022

Bug description

"Connect" button on the side of each workspace name on the list of workspaces leads to outdated workspace URLs (e.g. https://gitpodio-empty-z3ml0fq4itx.ws-eu51.gitpod.io/) when it should lead to https://gitpod.io/start/#gitpodio-empty-z3ml0fq4itx.

image

image

In this case, the error happened because the Cluster eu51 doesn't exist anymore. Using https://gitpod.io/start/# correctly leads the user to an actual cluster (eu53 at the time of writing).

Steps to reproduce

  • Create a workspace from gitpod.io UI.
  • Stop the workspace.
  • Open Gitpod Workspaces list in JetBrains Gateway.
  • Click the "Connect" button.
  • Observe the URL opened in the browser: it's the workspace URL from the last time it was opened.

Expected behavior

It should lead to an URL with the format https://gitpod.io/start/#<WORKSPACE_ID>.

@felladrin felladrin self-assigned this Jul 11, 2022
@felladrin felladrin moved this to Scheduled in 🚀 IDE Team Jul 11, 2022
@akosyakov
Copy link
Member

@felladrin We should align the logic here with dashboard. Just using start page is not enough, since it is another flow. IDE url in most case is the best option. I think it happens only when the cluster is gone. cc @aledbf @kylos101 correct?

@kylos101
Copy link
Contributor

@felladrin what is the first picture of? Is it the Gitpod Dashboard page, or some local JetBrains Gateway showing old workspaces?

@akosyakov assuming you can be certain the workspace is not running (or starting or stopping) and is truly off, I agree, you should link to something like https://gitpod.io/start/#<WORKSPACE_ID>.

@felladrin
Copy link
Contributor Author

@felladrin what is the first picture of? Is it the Gitpod Dashboard page, or some local JetBrains Gateway showing old workspaces?

The screenshot is from the workspaces list displayed inside JetBrains Gateway. [1]

@felladrin felladrin moved this from Scheduled to In Progress in 🚀 IDE Team Jul 21, 2022
@felladrin felladrin moved this from In Progress to In Review in 🚀 IDE Team Jul 21, 2022
@loujaybee loujaybee moved this from In Review to Awaiting Deployment in 🚀 IDE Team Jul 26, 2022
@akosyakov akosyakov moved this from Awaiting Deployment to Done in 🚀 IDE Team Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants