-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installation-telemetry] Add licenseType to sent telemetry #10688
Conversation
/werft run no-preview publish-to-kots 👍 started the job as gitpod-build-alt-10508-sh-telem-license-type.1 |
started the job as gitpod-build-alt-10508-sh-telem-license-type.2 because the annotations in the pull request description changed |
LGTM! :) |
Many thanks! I can take a look for team WebApp. 👀
While trying to see if this information was visible in this PR's preview environment, I ran into this issue: Does the preview environment need to be re-created? Or, should I be using some other preview? (E.g. I have no idea what |
Same problem with the command line test instruction:
When I open this Pull Request in Gitpod, and try
How can I get into the right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, anyway, the WebApp code changes do look good (and safe) to me, and the Self-Hosted parts were already approved, so I'm happy to just rubberstamp-approve on behalf of team WebApp without going through the full test flow. 🙂
Thanks again! 👍
Description
This pull request adds the Gitpod license type (replicated, gitpod) to installation telemetry.
Related Issue(s)
Fixes #10508.
How to test
Installation telemetry should include the
licenseType
field in the dashboard Admin page and the installation telemetry job:Release Notes
Documentation
This change is not user configurable and has no impact upon operations and use; no documentation is necessary.