Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installation-telemetry] Add licenseType to sent telemetry #10688

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

adrienthebo
Copy link
Contributor

@adrienthebo adrienthebo commented Jun 15, 2022

Description

This pull request adds the Gitpod license type (replicated, gitpod) to installation telemetry.

Related Issue(s)

Fixes #10508.

How to test

Installation telemetry should include the licenseType field in the dashboard Admin page and the installation telemetry job:

installation telemetry install type

❯ kubectl logs installation-telemetry-manual-0001-lwr54 | jq .
{
  "level": "info",
  "message": "installation-telemetry has successfully sent data - exiting",
  "serviceContext": {
    "service": "installation-telemetry",
    "version": "commit-efde5061d789299a2c5273d38d13376083fb4816"
  },
  "severity": "INFO",
  "telemetry": {
    "userId": "822b56b6-6e51-4d74-afbb-900399356a1f",
    "event": "Installation telemetry",
    "timestamp": "0001-01-01T00:00:00Z",
    "properties": {
      "licenseType": "replicated",
      "totalInstances": 0,
      "totalUsers": 1,
      "totalWorkspaces": 0,
      "version": "alt-10508-sh-telem-license-type.1"
    }
  },
  "time": "2022-06-15T23:22:44Z"
}

Release Notes

[installation-telemetry] The gitpod license type has been added to telemetry sent upon installation.

Documentation

This change is not user configurable and has no impact upon operations and use; no documentation is necessary.

@adrienthebo
Copy link
Contributor Author

adrienthebo commented Jun 15, 2022

/werft run no-preview publish-to-kots

👍 started the job as gitpod-build-alt-10508-sh-telem-license-type.1
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-alt-10508-sh-telem-license-type.2 because the annotations in the pull request description changed
(with .werft/ from main)

@adrienthebo adrienthebo marked this pull request as ready for review June 16, 2022 13:52
@adrienthebo adrienthebo requested review from a team June 16, 2022 13:52
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 16, 2022
@adrienthebo adrienthebo added do-not-merge/hold and removed team: webapp Issue belongs to the WebApp team do-not-merge/hold labels Jun 16, 2022
@lucasvaltl
Copy link
Contributor

LGTM! :)

@corneliusludmann corneliusludmann added the team: webapp Issue belongs to the WebApp team label Jun 21, 2022
@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 22, 2022

Many thanks! I can take a look for team WebApp. 👀

How to test

Installation telemetry should include the licenseType field in the dashboard Admin page and the installation telemetry job:

While trying to see if this information was visible in this PR's preview environment, I ran into this issue:

Screenshot 2022-06-22 at 17 37 24

Does the preview environment need to be re-created? Or, should I be using some other preview? (E.g. I have no idea what publish-to-kots does or how to test what was published there.)

@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 22, 2022

Same problem with the command line test instruction:

❯ kubectl logs installation-telemetry-manual-0001-lwr54 | jq .

When I open this Pull Request in Gitpod, and try kubectl get pods, I get zero running pods:

$ kubectl get pods
No resources found in staging-alt-10508-a182cf58db namespace.

How can I get into the right kubectl context? 👀

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, anyway, the WebApp code changes do look good (and safe) to me, and the Self-Hosted parts were already approved, so I'm happy to just rubberstamp-approve on behalf of team WebApp without going through the full test flow. 🙂

Thanks again! 👍

@roboquat roboquat merged commit 2e83668 into main Jun 22, 2022
@roboquat roboquat deleted the alt/10508-sh-telem-license-type branch June 22, 2022 15:43
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production release-note size/XS team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand self-hosted telemetry to include installer type (gitpod, kots)
5 participants