Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] implement feedback modal 9928 #10061

Merged
merged 1 commit into from
May 20, 2022
Merged

[dashboard] implement feedback modal 9928 #10061

merged 1 commit into from
May 20, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented May 17, 2022 •
edited
Loading

Description

Implements feedback tab on the top nav and shows a feedback modal on click.
This also sends a tracking event to Segment with the event name feedback_submitted.

First flow Second flow Analytics
Screenshot 2022-05-18 at 17 42 45 Screenshot 2022-05-18 at 17 42 55 Screenshot 2022-05-17 at 15 17 34

Related Issue(s)

Fixes #9928

How to test

Functionality test:

  1. Go to the top nav and click on the Feedback tab. (Ideally, this change in the nav would be hidden behind a feature flag if this PR is merged earlier, but we can also use the feature flag for the error messages.)
  2. Select an emoji.
  3. Enter a feedback text, or not.
  4. Submit feedback.

Analytics test:

After sending a feedback in the steps above, go to https://app.segment.com/gitpod/sources/staging_untrusted/debugger and find feedback_submitted events.

Release Notes

Users can send feedback from the Dashboard.

Documentation

/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch 3 times, most recently from 2759941 to a948ca9 Compare May 17, 2022 12:52
@laushinka laushinka marked this pull request as ready for review May 17, 2022 12:52
@laushinka laushinka requested a review from a team May 17, 2022 12:52
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 17, 2022
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from a948ca9 to b3807e7 Compare May 17, 2022 12:57
@laushinka laushinka requested review from jldec, gtsiolis and jakobhero May 17, 2022 13:09
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from b3807e7 to 1dcf7dc Compare May 17, 2022 16:21
@roboquat roboquat added size/XL and removed size/L labels May 17, 2022
jldec
jldec approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold pending engineering review
I love it! Excellent UI work (hover states, keyboard interaction)
Q: Will you do separate PR for feedback on error conditions?

jakobhero
jakobhero approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@jakobhero jakobhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tracking-wise. i noticed that the text in the feedback box was not visible for me unless i highlighted it though - might be due to the dark theme i use...

Screenshot 2022-05-17 at 20 41 31

components/dashboard/src/Analytics.tsx Show resolved Hide resolved
@laushinka
Copy link
Contributor Author

Will you do separate PR for feedback on error conditions?

Yes, I have a draft PR already, but have more questions. Will ping you.

@gtsiolis
Copy link
Contributor

gtsiolis commented May 18, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

gtsiolis
gtsiolis reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, @laushinka! 🔮

Added a few comments below regarding UX.

components/dashboard/src/Menu.tsx Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackModal.tsx Show resolved Hide resolved
gtsiolis
gtsiolis reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few more notes regarding dark theme layout.

giphy (1)

components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from f3bb306 to 53d87b7 Compare May 18, 2022 14:08
@roboquat roboquat added size/L and removed size/XL labels May 18, 2022
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch 2 times, most recently from 8519a62 to 063ff59 Compare May 18, 2022 15:11
@laushinka laushinka requested a review from gtsiolis May 18, 2022 15:14
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from 063ff59 to 8292fef Compare May 18, 2022 15:42
gtsiolis
gtsiolis reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round two, ready! 🥊

Thanks for the swift changes, @laushinka! 🙏

components/dashboard/src/feedback-form/FeedbackModal.tsx Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Show resolved Hide resolved
components/dashboard/src/feedback-form/FeedbackComponent.tsx Outdated Show resolved Hide resolved
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from 8292fef to af1b489 Compare May 18, 2022 16:26
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from af1b489 to 2fd9cbe Compare May 18, 2022 16:40
@laushinka laushinka changed the title Laushinka/implement feedback modal 9928 [dashboard] implement feedback modal 9928 May 19, 2022
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from 2fd9cbe to 3d45b5e Compare May 19, 2022 09:03
@laushinka laushinka requested a review from andrew-farries May 19, 2022 09:05
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from 3d45b5e to 39ceb98 Compare May 19, 2022 09:52
@gtsiolis gtsiolis mentioned this pull request May 19, 2022
Closed
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch 2 times, most recently from 992d210 to 70d8c4d Compare May 19, 2022 12:59
@laushinka laushinka requested a review from andrew-farries May 19, 2022 13:01
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from 70d8c4d to 9916241 Compare May 19, 2022 13:13
@laushinka laushinka force-pushed the laushinka/implement-feedback-modal-9928 branch from 19c6f6d to 841976b Compare May 20, 2022 07:17
@roboquat roboquat merged commit a56ef0a into main May 20, 2022
@roboquat roboquat deleted the laushinka/implement-feedback-modal-9928 branch May 20, 2022 07:28
@laushinka
Copy link
Contributor Author

Thank you for the reviews, all!

@gtsiolis gtsiolis mentioned this pull request May 20, 2022
Closed
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis left review comments

@jakobhero jakobhero jakobhero approved these changes

@andrew-farries andrew-farries andrew-farries approved these changes

@jldec jldec jldec approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement feedback modal
6 participants
@laushinka @gtsiolis @jldec @andrew-farries @jakobhero @roboquat