Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback successful submission step in the feedback modal #10124

Closed
gtsiolis opened this issue May 19, 2022 · 2 comments
Closed

Add feedback successful submission step in the feedback modal #10124

gtsiolis opened this issue May 19, 2022 · 2 comments
Assignees
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented May 19, 2022

Problem to solve

Following up from the discussion in #10061 (comment), the feedback modal currently lacks a successful submission step.

  1. We're missing a confirmation step to provide some feedback to users that we've received their feedback. Currently, when submitting the form, it feels like you are throwing something out of a cliff, no?
  2. For the same reason, when you are pressing enter on the second step, it's not entirely clear that your feedback has been sent.

Cc @laushinka because #10061
Cc @jldec because #7925

Proposal

Add a feedback successful submission step in the feedback modal.

Designs

Early design from the linked discussion above
Modal

See design specs for grabbing the emoji SVG.

@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels May 19, 2022
@laushinka
Copy link
Contributor

@gtsiolis Should we close this because implemented in #10071?

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Jun 1, 2022

Thank you for coming back to this, @laushinka! ✨

The UX issue described here seems still valid (see screenshot below) but we did add the feedback successful submission step in #10071. ✔️

The UX issues are also mentioned in the following two comments which are included in the follow-up issue in #10307:

  1. Laushinka/error form 10062 #10071 (comment)
  2. Laushinka/error form 10062 #10071 (comment)

Closing this, and referencing the proposal from the issue description in the follow up issue in #10307, see point [9] in the issue description. 📕

PROPOSAL PRODUCTION
Modal Screenshot 2022-06-01 at 11 05 55 AM (2)

@gtsiolis gtsiolis closed this as completed Jun 1, 2022
@gtsiolis gtsiolis moved this to Done in 🍎 WebApp Team Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: No status
Development

No branches or pull requests

2 participants