Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading indicator when fetching branches and prebuilds #5351

Closed
gtsiolis opened this issue Aug 24, 2021 · 10 comments · Fixed by #6984
Closed

Add loading indicator when fetching branches and prebuilds #5351

gtsiolis opened this issue Aug 24, 2021 · 10 comments · Fixed by #6984
Assignees
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team user experience

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Loading Branches and Prebuilds for a project can still take a while for active projects, see #5038.

Proposal

Until there's a better way to resolve these perfomance issues, we could introduce a loading indicator when fetching branches and prebuilds to improve the user experience.

This could use the loading indicator being introduced in #5236, see relevant diff. ⚫

Branches Prebuilds
Bracnhes Prebuilds
@gtsiolis gtsiolis added user experience component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. labels Aug 24, 2021
@atduarte
Copy link
Contributor

It would be also good to do something similar in the prebuild page, as it starts with an "unknown prebuild" title

image

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 24, 2021

@jankeromnes since you added the loading indicator on the Branches page in #5809, do you think it makes sense to do the same for the Prebuilds page as it could be slightly slow to fetch prebuilds for active projects. For example, see https://gitpod.io/t/gitpod/gitpod/prebuilds. ❓ Cc @AlexTugarev

@gtsiolis
Copy link
Contributor Author

Looping in @jldec for visibility.

@gtsiolis gtsiolis added meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team labels Nov 30, 2021
@jankeromnes
Copy link
Contributor

Yes 👍 happy to add these.

@jankeromnes jankeromnes self-assigned this Nov 30, 2021
@JanKoehnlein
Copy link
Contributor

/schedule

@roboquat
Copy link
Contributor

@JanKoehnlein: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jankeromnes
Copy link
Contributor

/schedule

Woohoo! Rock'n'roll 😎

@jankeromnes
Copy link
Contributor

/assign

@jankeromnes
Copy link
Contributor

jankeromnes commented Nov 30, 2021

PR: #6984

TODO:

  • Loading indicator for Branches
  • Loading indicator for Prebuilds
  • Stretch goal: Loading indicator / skeleton loader for Prebuild
  • Stretch goal: Loading indicator / skeleton loader for Projects

EDIT: (Edited based on #5351 (comment) 🙏)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Nov 30, 2021

Loading indicator for Projects

This was also briefly mentioned in a past meta team meeting in regards to #6118 and #6121.

A loading indicator could be a good MVC and a skeleton loader could be even better in a future iteration for the Projects and Prebuild pages due to page structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team user experience
Projects
No open projects
Status: Low hanging fruits 🍒
Development

Successfully merging a pull request may close this issue.

5 participants