Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a full-page loading indicator for the dashboard #16803

Closed
gtsiolis opened this issue Mar 10, 2023 · 5 comments · Fixed by #16984
Closed

Add a full-page loading indicator for the dashboard #16803

gtsiolis opened this issue Mar 10, 2023 · 5 comments · Fixed by #16984
Assignees
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 10, 2023

Problem to solve

Loading the dashboard sometimes can take longer than usual.

This also affect staging.

See relevant discussion (internal). Cc @AlexTugarev @svenefftinge

Proposal

Some thoughts on loading:

  • Loading strategies
    • Skeleton loaders
    • Loading indicators
      • Full-page loading (This issue!)
      • Inline loading
    • Progressive loading
    • Load more options

For the scope of this issue, we can re-use the Loader component for adding a full-page loading when the entire page is processing, see designs below.

Full-page loading
Frame 1290
@gtsiolis gtsiolis added help wanted component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Mar 10, 2023
@himanshu1221
Copy link

can I give it a try?

@gtsiolis
Copy link
Contributor Author

Absolutely, @himanshu1221! Feel free to open a pull request and link back to this comment. 🏓

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 21, 2023

Cross-posting from a relevant discussion (internal) and #16941 which we may need to revert once we have the full-page loading indicator in place. Cc @geropl @AlexTugarev

@gtsiolis:
❓ For the next iteration, shall we investigate a full-page loading indicator? See relevant discussion and #16803.
❗ The interaction seems a bit jarring as the switch of the org happens after ~3-5 seconds.
❗ This also breaks permalinks for projects. For example, you can no longer link directly to the gitpod project.
❗ The interaction UX will become more jarring when we split the workspace attribution per org and the workspaces list re-renders, see #15980.

@gtsiolis
Copy link
Contributor Author

@himanshu1221 Heads-up that @selfcontained started working on this as this became a priority issue. 🏓

@himanshu1221
Copy link

@himanshu1221 Heads-up that @selfcontained started working on this as this became a priority issue. 🏓

No worries

@github-project-automation github-project-automation bot moved this from In Progress to In Validation in 🍎 WebApp Team Mar 23, 2023
@geropl geropl moved this from In Validation to Done in 🍎 WebApp Team Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants