Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the full-page loading indicator #17044

Closed
gtsiolis opened this issue Mar 27, 2023 · 6 comments
Closed

Improve the full-page loading indicator #17044

gtsiolis opened this issue Mar 27, 2023 · 6 comments
Labels
aspect: gitpod loading process Related to the loading order of Gitpod processes, such as env variables, IDE, dotfiles etc component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Back in #16803 and #16984, a full-page loading indicator was added while loading the dashboard.

Although, this significantly improves the dashboard by not showing a blank white page on load, there's room to improve this page and also avoid confusing users. From #16984 (comment):

@gtsiolis: Re-using the bouncing logo could frustrate or confuse users as they usually to see that loading state (bouncing logo) a lot while opening workspaces.

The current state also lacks a loading indication, as the logo remains still, which could confuse users even more as the layout resembles the error page, besides the workspace start page.

Full-page loading Error Start
Screenshot 2023-03-27 at 12 55 08 Screenshot 2023-03-27 at 12 55 15 Screenshot 2023-03-27 at 13 01 52

Proposal

Replace the current full-page loading in indicator with the (animated) spinner animation.

BEFORE AFTER
Screenshot 2023-03-23 at 11 20 36 224318369-368eaa86-4bc1-4bfa-a18b-5cab5f3f775d
@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team aspect: gitpod loading process Related to the loading order of Gitpod processes, such as env variables, IDE, dotfiles etc labels Mar 27, 2023
@himanshu1221
Copy link

Can I give it a try @gtsiolis?

@gtsiolis
Copy link
Contributor Author

Sure, @himanshu1221! 🏓

@vedant-jain03
Copy link
Contributor

@himanshu1221 In case you are not working on this issue, please let me know, I would love to work on this!

@himanshu1221
Copy link

@himanshu1221 In case you are not working on this issue, please let me know, I would love to work on this!

Yes @vedant-jain03 i am still trying

@RayAsh37
Copy link
Contributor

to sum-up, the current loading page content should be entirely replaced by just a plain Spinner. am I right @gtsiolis ?

@RayAsh37 RayAsh37 mentioned this issue Apr 26, 2023
14 tasks
@gtsiolis
Copy link
Contributor Author

Hey @RayAsh37! Chatted with the team about this internally and decided we're going to keep the current version for now. Thanks for hanging here, let me close this for now. 📕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: gitpod loading process Related to the loading order of Gitpod processes, such as env variables, IDE, dotfiles etc component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

4 participants