-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
7a411da
to
a6b8e0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mkdir -p ~/.config/gcloud | ||
open .env | ||
gcloud auth login | ||
make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you run make install
at the end of this won't it try to just launch the installer with the example values? That is before this user has had the chance to modify to suit their account. Perhaps a make help
so they see what the options are plus a "edit .env and run make install when you are ready"
That confused me for a minute before I realized I didn't do anything wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, I opened the workspace saw the Google oauth prompt right away, connected that, before I edited the env. Knee jerk reaction to being prompted for a login, "do it quickly or something will timeout". Then I wasn't sure how to restart. Had to dig into the gitpod to understand get to oh just re-run make install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree this can be further streamlined. Maybe the install should initially check for the required env vars (BILLING_ACCOUNT and DOMAIN) and fail early if they haven't been set.
That said I'm still not sure what to do about the DOMAIN at all 😁
For visibility, I'd like to get the rest of the work required on #12 finished off before we look at this. It may be that much of the Installer stuff fixes these issues and, in any case, there's likely to be conflicts between the two |
Thanks for the heads up. Any eta on when the PR lands? |
@svenefftinge I've set it as my team target to complete it this week |
I'm going to close this as we'll be doing a complete overhaul of the guides in the new year |
@mrsimonemms could you add some context, please? |
@ionutale we're moving to a monthly release cycle before the end of Jan. The docs will be released at the same time |
This PR adds a config so that users can run the installer from within gitpod.
It also fixes #6 and runs some commands (e.g. creating and opening
.env
) to streamline the process.