Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trial messaging #3720

Closed
wants to merge 7 commits into from
Closed

Conversation

sergiolms
Copy link
Contributor

@sergiolms sergiolms commented Nov 7, 2024

Description

Solves #3715

This PR changes trial messages for Pro Trial available and Trial expired states in:

  • Account view

  • Launchpad

  • Visual File History

  • Worktrees

  • Cloud Patches

  • Verify Email

  • Changes to Graph's 3 day feature preview trial messages are addressed here.

  • Changes for 7 -> 14 day trial are addressed here.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergiolms sergiolms self-assigned this Nov 7, 2024
@sergiolms sergiolms changed the title 3715 Update trial messaging Update trial messaging Nov 7, 2024
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing inconsistencies between the messaging in the Figma from the linked issue and the messaging on the gates:

image

image

image

image

image

image

image

image

@sergiolms sergiolms force-pushed the chore/3715_update_trial_messaging branch from 8a45fa3 to 2504d02 Compare November 8, 2024 16:17
@d13 d13 linked an issue Nov 8, 2024 that may be closed by this pull request
@eamodio eamodio added this to the 16.0 milestone Nov 11, 2024
@sergiolms sergiolms force-pushed the chore/3715_update_trial_messaging branch 2 times, most recently from d112dd0 to 2a92d3e Compare November 11, 2024 16:43
@justinrobots
Copy link
Collaborator

@sergiolms I'm still seeing the options for a 3 day preview trial on Visual File History and Worktrees. These should not exist. Are they removed in a separate PR, or should they not be showing up in this one?
image
image

@justinrobots
Copy link
Collaborator

@sergiolms this should be using "Get x days of GitLens Pro for free - no credit card required. Or sign in." instead of "Start your free x-day GitLens Pro trial - no credit card required. Or sign in".
image

@justinrobots
Copy link
Collaborator

@sergiolms is it possible to change the link styles in the graph modals to match the designs? Currently, they are underlined white text, but they were changed to the blue link style in the design (the same style used for Commit Graph in these modals)
image
image

@justinrobots
Copy link
Collaborator

justinrobots commented Nov 11, 2024

@sergiolms this notification that pops up when users start the 3 day graph preview is still referencing "local Pro features" but should just be about the graph.

  • Please change this to "You can now preview the Commit Graph on privately-hosted repos for 3 days, or start your free x-day Pro trial for full access to all GitLens Pro features."
  • Make "GitLens Pro" a link to the Community vs. Pro page like the other messages
  • Remove the secondary button for "See Pro Features"
image

@sergiolms
Copy link
Contributor Author

Hi @justinrobots

@sergiolms I'm still seeing the options for a 3 day preview trial on Visual File History and Worktrees. These should not exist. Are they removed in a separate PR, or should they not be showing up in this one?

I was meaning to upload it in a separate PR, but I can just add a commit here if it's clearer 👍

@sergiolms this notification that pops up when users start the 3 day graph preview is still referencing "local Pro features" but should just be about the graph.

I changed this in the Graph 3-day preview feature. This notification should only appear when starting the 3 day preview for the Commit graph, since it won't be possible to start it from anywhere else, right? But if I remember correctly, we agreed on not displaying the notification since it would pop up every day, and instead we would just display the modal every 24h. Those changes are applied in the linked PR, but l'll change this notification in this PR as well just in case.

@sergiolms sergiolms force-pushed the chore/3715_update_trial_messaging branch from b7f998d to eba2fb2 Compare November 12, 2024 13:27
@sergiolms
Copy link
Contributor Author

Solves #3694

@sergiolms
Copy link
Contributor Author

Changes from this PR will be included in #3714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update trial messaging
4 participants