-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trial messaging #3720
Update trial messaging #3720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8a45fa3
to
2504d02
Compare
d112dd0
to
2a92d3e
Compare
@sergiolms I'm still seeing the options for a 3 day preview trial on Visual File History and Worktrees. These should not exist. Are they removed in a separate PR, or should they not be showing up in this one? |
@sergiolms this should be using "Get x days of GitLens Pro for free - no credit card required. Or sign in." instead of "Start your free x-day GitLens Pro trial - no credit card required. Or sign in". |
@sergiolms is it possible to change the link styles in the graph modals to match the designs? Currently, they are underlined white text, but they were changed to the blue link style in the design (the same style used for |
@sergiolms this notification that pops up when users start the 3 day graph preview is still referencing "local Pro features" but should just be about the graph.
|
I was meaning to upload it in a separate PR, but I can just add a commit here if it's clearer 👍
I changed this in the Graph 3-day preview feature. This notification should only appear when starting the 3 day preview for the Commit graph, since it won't be possible to start it from anywhere else, right? But if I remember correctly, we agreed on not displaying the notification since it would pop up every day, and instead we would just display the modal every 24h. Those changes are applied in the linked PR, but l'll change this notification in this PR as well just in case. |
b7f998d
to
eba2fb2
Compare
Solves #3694 |
Changes from this PR will be included in #3714 |
Description
Solves #3715
This PR changes trial messages for Pro Trial available and Trial expired states in:
Account view
Launchpad
Visual File History
Worktrees
Cloud Patches
Verify Email
Changes to Graph's 3 day feature preview trial messages are addressed here.
Changes for 7 -> 14 day trial are addressed here.
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses