-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3687: Implement a Pro feature preview for the graph #3714
Closed
sergiolms
wants to merge
16
commits into
main
from
feature/3687_implement_pro_feature_preview_for_the_graph
Closed
#3687: Implement a Pro feature preview for the graph #3714
sergiolms
wants to merge
16
commits into
main
from
feature/3687_implement_pro_feature_preview_for_the_graph
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiolms
requested review from
d13,
eamodio,
justinrobots and
axosoft-ramint
November 5, 2024 13:09
sergiolms
force-pushed
the
feature/3687_implement_pro_feature_preview_for_the_graph
branch
2 times, most recently
from
November 5, 2024 15:58
b01b703
to
c3bd4d8
Compare
axosoft-ramint
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TS warnings when building:
Also, I'm seeing issues with the flow when testing it using the account simulator (debugging) in the Community state:
- The modal says "continuing gives you 7 days" when it should say 3 days
- Hitting the "continue" button links out to gkdev to register an account. If I recall correctly it should immediately start the preview, not require an account, right? Unless I'm interpreting the issue incorrectly.
sergiolms
force-pushed
the
feature/3687_implement_pro_feature_preview_for_the_graph
branch
from
November 8, 2024 14:30
6f68c81
to
9d0dbbb
Compare
sergiolms
force-pushed
the
feature/3687_implement_pro_feature_preview_for_the_graph
branch
2 times, most recently
from
November 12, 2024 15:29
b8e2b92
to
9c0071d
Compare
sergiolms
force-pushed
the
feature/3687_implement_pro_feature_preview_for_the_graph
branch
from
November 13, 2024 11:54
9c0071d
to
21ad073
Compare
Closing in favor of 3d4b046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additionally, it includes changes from #3720 and #3694
Solves #3715
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses