Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about-pull-requests.md #483

Merged
merged 4 commits into from
Oct 15, 2020

Conversation

Ruth-ikegah
Copy link
Contributor

Why:

This PR fixes #430

What's being changed:

A section has been added about clarifying the difference in the commits displayed shown on the compare page and what's shown on a pull request page.

Check off the following:

@janiceilene
Copy link
Contributor

Thanks @Ruth-ikegah! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 13, 2020
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 Hi @Ruth-ikegah, thanks for adding this information 😄

It looks as if the issue you were working from was transferred from a really old (2017) internal issue. This was before we started localizing content so the suggested text was out of line with our current recommendations. I've made suggestions to bring it into line.

@Ruth-ikegah
Copy link
Contributor Author

👋🏻 Hi @Ruth-ikegah, thanks for adding this information 😄

It looks as if the issue you were working from was transferred from a really old (2017) internal issue. This was before we started localizing content so the suggested text was out of line with our current recommendations. I've made suggestions to bring it into line.

Thanks for this amazing review @felicitymay I really learnt a lot. I have applied the suggested changes. Thanks.

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really glad you found the review helpful ✨

This looks ready to merge once the tests pass on the updated branch.

I've just noticed from your profile that you're a fellow technical writer. We're a fairly rare species, so it's particularly lovely to meet you 😄

@felicitymay felicitymay merged commit 77f286a into github:main Oct 15, 2020
@Ruth-ikegah
Copy link
Contributor Author

I'm really glad you found the review helpful ✨

This looks ready to merge once the tests pass on the updated branch.

I've just noticed from your profile that you're a fellow technical writer. We're a fairly rare species, so it's particularly lovely to meet you 😄

Thanks! It is a pleasure meeting you too. I hope to learn more from you. Is there a community chat for @github docs yet?

@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@felicitymay
Copy link
Contributor

Is there a community chat for @github docs yet?

That's a great question and I don't know the answer. I'll pass it on to the person who's leading the open source initiative ✨

@janiceilene
Copy link
Contributor

👋 @Ruth-ikegah! I'm talking about open sourcing the docs during Open Source Friday tomorrow! Is that what you're referring to or something else? I'm definitely interested in hearing about what you think would be helpful for folks!

@Ruth-ikegah
Copy link
Contributor Author

👋 @Ruth-ikegah! I'm talking about open sourcing the docs during Open Source Friday tomorrow! Is that what you're referring to or something else? I'm definitely interested in hearing about what you think would be helpful for folks!

Nice I just registered, will be attending. I was referring to something like a community chat channel where contributors of Github docs can network and share ideas.

@felicitymay felicitymay added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify which point in each branch is compared in a pull request
4 participants