Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify which point in each branch is compared in a pull request #430

Closed
megbird opened this issue Oct 12, 2020 · 1 comment · Fixed by #483
Closed

Clarify which point in each branch is compared in a pull request #430

megbird opened this issue Oct 12, 2020 · 1 comment · Fixed by #483
Labels
good first issue Good for newcomers

Comments

@megbird
Copy link
Contributor

megbird commented Oct 12, 2020

Some users are confused about the difference in the commits displayed shown on the compare page and what's shown in a PR.

We talk about what a compare page shows in "About comparing branches in pull requests;" we can add some simple to "About pull requests."

Compare pages show a compare between the tip of the head ref and the current common ancestor (i.e. merge base) of the head and base ref. On the other hand, pull request pages show a compare between the tip of the head ref and the common ancestor of the head and base ref at the time when the pull request was created. In other words, the merge base used for the comparison might be different.
@megbird megbird added good first issue Good for newcomers triage Do not begin working on this issue until triaged by the team labels Oct 12, 2020
@janiceilene janiceilene removed the triage Do not begin working on this issue until triaged by the team label Oct 13, 2020
@Ruth-ikegah
Copy link
Contributor

I want to take this up!

@Ruth-ikegah Ruth-ikegah mentioned this issue Oct 13, 2020
Merged
4 tasks
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this issue Oct 6, 2022
@jacobprall
Fix/linkchecker (github#430)
83f6757 
* add excludes

* update

* update
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this issue Oct 6, 2022
@jacobprall @Loquacity
@camscale @jonatas @Taadas @erimatnor
Feature/project prince jacob (github#493)
50a5365 
* initial setup

* remove update search index for now

* major overhaul - links to console and new portal not changed

* index page for mst

* mst-multi-node

* finish mst section content

* convert forge links

* General edits for wording, etc. (github#381)

* update (github#386)

* Add command to install timescaledb-tools (github#364)

* Fix missing semi-colon (github#363)

Co-authored-by: Jacob Prall <[email protected]>

* Remove 'repeatable' isolation level from multinode docs (github#361)

Co-authored-by: Jacob Prall <[email protected]>

* Fix bad path (github#360)

* add leading slash

* Add version

* typo

Co-authored-by: Jacob Prall <[email protected]>

* Update install instructions (github#359)

* Update install instructions

* Change postgres to timescaledb repo

* Add sudo

* Remove extra whitespace

* Update to correct key

* Edits per feedback

* Add step to install postgres repo

* Apply suggestions from code review

Co-authored-by: Cam Hutchison <[email protected]>

Co-authored-by: Cam Hutchison <[email protected]>
Co-authored-by: Jacob Prall <[email protected]>

* Fix/link checker error (github#370)

* add absolute path to links

* add slash

* Fix incorrect sql query (github#362)

Co-authored-by: Jacob Prall <[email protected]>

* Add the toolkit as a pre-req to the tutorial. (github#306)

* Add the toolkit as a pre-req to the tutorial.

* Fix link in admon

* Point to correct URL

* fix link

Co-authored-by: Jacob Prall <[email protected]>

* Fix/link checker error (github#374)

* add absolute path to links

* add slash

* add base url

* add new to ignore

* Fix/link checker error (github#376)

* add absolute path to links

* add slash

* add base url

* add new to ignore

* add scheme

* Document the differences between time_bucket() and time_bucket_ng() (github#354)

Document the differences between time_bucket() and time_bucket_ng()

Co-authored-by: Lana Brindley <[email protected]>

* Update install instructions (github#379)

* Update install instructions

* Update timescaledb/how-to-guides/install-timescaledb/installation-apt-debian.md

Co-authored-by: Jacob Prall <[email protected]>

* Add metadata for tutorials (github#380)

* Add metadata for tutorials

* Update page-index.js

typo correction

Co-authored-by: Jacob Prall <[email protected]>

* Update page-index.js

Co-authored-by: Lana Brindley <[email protected]>
Co-authored-by: Cam Hutchison <[email protected]>
Co-authored-by: Aleksander Alekseev <[email protected]>

* change to cloud

* cloud

* Update time_bucket_ng.md (github#417)

* Update cloud/cloud-multi-node.md

Co-authored-by: Lana Brindley <[email protected]>

* Update cloud/create-a-service.md

Co-authored-by: Lana Brindley <[email protected]>

* Update mst/create-a-service.md

Co-authored-by: Lana Brindley <[email protected]>

* Update timescaledb/tutorials/setting-up-mst-for-prometheus.md

Co-authored-by: Lana Brindley <[email protected]>

* Update timescaledb/tutorials/setting-up-mst-for-prometheus.md

Co-authored-by: Lana Brindley <[email protected]>

* Update timescaledb/tutorials/setting-up-mst-for-prometheus.md

Co-authored-by: Lana Brindley <[email protected]>

* Update timescaledb/tutorials/setting-up-mst-for-prometheus.md

Co-authored-by: Lana Brindley <[email protected]>

* Update timescaledb/tutorials/setting-up-mst-for-prometheus.md

Co-authored-by: Lana Brindley <[email protected]>

* Update cloud/create-a-service.md

Co-authored-by: Lana Brindley <[email protected]>

* Update time_bucket_ng.md

* Update cloud/create-a-service.md

Co-authored-by: Lana Brindley <[email protected]>

* update portal managed

* Feature/timescale license comparison (github#453)

* added timescale license comparison

* edit title

* update

* Make sure window functions are listed as unsupported (github#393)

Co-authored-by: Jacob Prall <[email protected]>

* update link (github#420)

* update (github#422)

* Fix/update link checker (github#424)

* update

* don't check if starts with /

* add excludes (github#426)

* Fix/linkchecker (github#428)

* add excludes

* update

* Fix/linkchecker (github#430)

* add excludes

* update

* update

* Fix/linkchecker (github#432)

* add excludes

* update

* update

* comment out link checker

* Fix/link checker again (github#433)

* try to include link checker

* reinstate index rebuild on merge

* tweak yaml

* remove link detector

* tweak curl

* remove link checker

* remove search index from deploy

* tweak update search

* update search index

* change name of action

* stop search index for now

* ignore search update

* remove update search index

* Add .NET C# quick start tutorial (github#412)

* Add C# dotnet quickstart

* Update dotnet.md

Fixing steps to have numbers, a few heading formatting issues, and changing the "step" text above each method.

* Apply suggestions from code review

Applying most changes. I want to verify that auto numbering will work across code sections before accepting those.

Co-authored-by: Lana Brindley <[email protected]>

* Apply suggestions from code review

Co-authored-by: Lana Brindley <[email protected]>

* Update dotnet.md

Co-authored-by: Ryan Booz <[email protected]>
Co-authored-by: Lana Brindley <[email protected]>

* update copy

* update copy

* add edition

* Fix typo in JSON docs (github#441)

Co-authored-by: Tadas Malinauskas <[email protected]>

* Clarify behavior when deleting a data node (github#406)

* Clarify behavior when deleting a data node

When deleting a data node, the database (including its data) on the
data node is left intact. This sometimes confuses users and this
change clarifies this behavior and adds explanations for why this
behavior exists.

* Update api/delete_data_node.md

Co-authored-by: Lana Brindley <[email protected]>

* Update api/delete_data_node.md

Co-authored-by: Lana Brindley <[email protected]>

* Apply suggestions from code review

minor copy edits

Co-authored-by: Lana Brindley <[email protected]>

Co-authored-by: Jacob Prall <[email protected]>
Co-authored-by: Lana Brindley <[email protected]>

* Update README.md

add newLabel to page-index read me

* Add link to developer docs on GH (github#438)

* Add link to developer docs on GH

* Add link to developer docs on install page

* remove new item

Co-authored-by: Lana Brindley <[email protected]>
Co-authored-by: Jônatas Davi Paganini <[email protected]>
Co-authored-by: Ryan Booz <[email protected]>
Co-authored-by: Tadas Malinauskas <[email protected]>
Co-authored-by: Tadas Malinauskas <[email protected]>
Co-authored-by: Erik Nordström <[email protected]>

* Update timescaledb-license-comparison.md

* update timescale table

* add terms of service links

* update

* add terms of service links

* Update timescaledb-license-comparison.md

* Update timescaledb-license-comparison.md

Co-authored-by: Lana Brindley <[email protected]>
Co-authored-by: Cam Hutchison <[email protected]>
Co-authored-by: Aleksander Alekseev <[email protected]>
Co-authored-by: Jônatas Davi Paganini <[email protected]>
Co-authored-by: Ryan Booz <[email protected]>
Co-authored-by: Tadas Malinauskas <[email protected]>
Co-authored-by: Tadas Malinauskas <[email protected]>
Co-authored-by: Erik Nordström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update about-pull-requests.md Ruth-ikegah/docs
3 participants
@megbird @janiceilene @Ruth-ikegah