Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle windows paths in product definitions #351

Closed
wants to merge 2 commits into from
Closed

handle windows paths in product definitions #351

wants to merge 2 commits into from

Conversation

jeffmcaffer
Copy link
Contributor

Why:

resolves #316

What's being changed:

product URLs are being computed based on file system paths so need to be slashed for Windows

Check off the following:

@jeffmcaffer jeffmcaffer added bug An error or flaw that causes unintended or unexpected results engineering Will involve Docs Engineering labels Oct 9, 2020
@jeffmcaffer jeffmcaffer requested a review from a team as a code owner October 9, 2020 15:54
heiskr
heiskr approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼 Thanks!

@chiedo chiedo mentioned this pull request Oct 9, 2020
Merged
4 tasks
@nschonni nschonni mentioned this pull request Nov 30, 2020
Closed
@github github locked as spam and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@heiskr heiskr heiskr approved these changes

@chiedo chiedo Awaiting requested review from chiedo

Assignees
No one assigned
Labels
bug An error or flaw that causes unintended or unexpected results engineering Will involve Docs Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

homepage calculation gives bad URLs on Windows
3 participants
@jeffmcaffer @heiskr @chiedo