Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old branches in this repo to reduce spam PRs #1644

Closed
nschonni opened this issue Nov 27, 2020 · 9 comments
Closed

Clean up old branches in this repo to reduce spam PRs #1644

nschonni opened this issue Nov 27, 2020 · 9 comments
Labels
engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team

Comments

@nschonni
Copy link
Contributor

What is the current behavior?

As a visible repo for people looking at the docs, this repo attracts alot of spam PRs. Some of these come from old merged/closed branches from GitHubbers that are automatically in forked repos.

What changes are you suggesting?

Delete old branches on https://github.com/github/docs/branches/all for Closed, Merged, and un-PR'd branches

Additional information

Don't think all GitHubber contributions need to be directed internal fork in all cases, as showing an active PR can help show that someone is working on one of the issues and can be useful for others to learn. Cleaning up those branches afterwards is a good idea though 😄

@nschonni nschonni added the engineering Will involve Docs Engineering label Nov 27, 2020
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 27, 2020
@chiedo
Copy link
Contributor

chiedo commented Nov 30, 2020

Deleted the really old ones! Left branches open that were created within the past couple weeks.

@chiedo chiedo closed this as completed Nov 30, 2020
@nschonni
Copy link
Contributor Author

Awesome!
I'd probably suggest this one too, since it is even with the main branch
image

@chiedo
Copy link
Contributor

chiedo commented Nov 30, 2020

I'm not sure why but I can't delete that branch.

Screen Shot 2020-11-30 at 11 30 52 AM

I can't find the corresponding pull request ¯_(ツ)_/¯

@nschonni
Copy link
Contributor Author

Looks like it's this PR #351

@chiedo
Copy link
Contributor

chiedo commented Nov 30, 2020

Yeah but it's closed so I don't understand why it's saying it can't be deleted due to an open PR. Maybe a bug. But not sure.

@nschonni
Copy link
Contributor Author

Ah, gotcha.
Sounds like it's time to spin up an internal bug 😆

@nschonni
Copy link
Contributor Author

I was thinking it might have been deletable from the actual PR page

@chiedo
Copy link
Contributor

chiedo commented Nov 30, 2020

Haha yeah. I'll submit an internal bug! haha. Thanks for digging in here.

@per1234
Copy link
Contributor

per1234 commented Apr 16, 2022

High time for another clean-up @chiedo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

No branches or pull requests

3 participants