Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clearer which platforms the CodeQL runner is compatible with #168

Closed
felicitymay opened this issue Oct 6, 2020 · 0 comments · Fixed by #195
Closed

Make it clearer which platforms the CodeQL runner is compatible with #168

felicitymay opened this issue Oct 6, 2020 · 0 comments · Fixed by #195
Labels
content This issue or pull request belongs to the Docs Content team

Comments

@felicitymay
Copy link
Contributor

Content strategy plan

Content plan

The lack of a mention of Windows in the Downloading the CodeQL runner section could make the user doubt whether Windows is supported by the runner.

Audience

Anyone installing the CodeQL runner who wants to verify that it will work in their system.

Content to update

Currently, Windows is not mentioned in this section because you don't need to make any particular changes to the downloaded file to make it executable.

Having discussed this with the user who gave this feedback, the recommended fix is to add an explanatory sentence to the end of the section. Something like:

On Windows, the codeql-runner-win.exe file usually requires no change to permissions.

Questions

None outstanding.
@janiceilene janiceilene transferred this issue from another repository Oct 7, 2020
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 7, 2020
@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team DSP and removed triage Do not begin working on this issue until triaged by the team labels Oct 7, 2020
casals added a commit to casals/docs that referenced this issue Oct 7, 2020
@casals
Update running-code-scanning-in-your-ci-system.md
e0c2d04 
Fixes github#168 with the proposed changes.
@casals casals mentioned this issue Oct 7, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update running-code-scanning-in-your-ci-system.md casals/docs
3 participants
@felicitymay @janiceilene and others