Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update running-code-scanning-in-your-ci-system.md #195

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

casals
Copy link
Contributor

@casals casals commented Oct 7, 2020

Why:

Fixes #168 with the proposed changes.

What's being changed:

As suggested by the linked issue's author, added an explanatory sentence to the end of the section. The new sentence reads:

"On Windows, the codeql-runner-win.exe file usually requires no change to permissions."

Check off the following:

@janiceilene
Copy link
Contributor

Thank you so much for this fix @casals! I'll leave this to the @github/docs-content-dsp team to review 💖

@janiceilene janiceilene added the DSP label Oct 7, 2020
@github github deleted a comment from hubot Oct 7, 2020
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @casals! This looks great 😊

@shati-patel shati-patel merged commit 5dd286b into github:main Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it clearer which platforms the CodeQL runner is compatible with
3 participants