Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usability of update dependencies workflow #1868

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Improve usability of update dependencies workflow #1868

merged 1 commit into from
Sep 5, 2023

Conversation

henrymercer
Copy link
Contributor

Improve the experience of using the updating dependencies workflow:

  • Mark the PR as draft if we pushed a commit to update the dependencies.
  • Add a comment asking the user to mark the PR as ready for review to trigger the checks.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 5, 2023 14:38
TomBolton
TomBolton approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@TomBolton TomBolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@henrymercer henrymercer merged commit 37d8d03 into main Sep 5, 2023
344 checks passed
@henrymercer henrymercer deleted the henrymercer/improve-dependency-update branch September 5, 2023 15:38
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Merged
6 tasks
webknjaz added a commit to ansible/pylibssh that referenced this pull request Jun 7, 2024
@webknjaz
🧪 Implement a draft based release PR CI trigger
2775134 
Normally, PRs/commits published using the default GitHub Actions CI/CD
API token are not propagated to any integrations. This patch marks the
release PR as a draft and leaves a comment asking the maintainers to
mark it as ready for review in order to actually trigger a CI run.

This idea is found in GitHub's own repos:
* github/codeql-action#2263 (comment)
* https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41
* github/codeql-action#1868
* github/codeql-action#679
webknjaz added a commit to webknjaz/pytest that referenced this pull request Jun 20, 2024
@webknjaz
🧪 Make a draft based plugin bump PR CI trigger
83bf818 
Normally, PRs/commits published using the default GitHub Actions CI/CD
API token are not propagated to any integrations. This patch marks the
plugin update PR as a draft and leaves a comment asking the maintainers to
mark it as ready for review in order to actually trigger a CI run.

This idea is found in GitHub's own repos:
* github/codeql-action#2263 (comment)
* https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41
* github/codeql-action#1868
* github/codeql-action#679
@webknjaz webknjaz mentioned this pull request Jun 20, 2024
Merged
webknjaz added a commit to webknjaz/pytest that referenced this pull request Jun 20, 2024
@webknjaz
🧪 Make a draft based plugin bump PR CI trigger
6303ba5 
Normally, PRs/commits published using the default GitHub Actions CI/CD
API token are not propagated to any integrations. This patch marks the
plugin update PR as a draft and leaves a comment asking the maintainers to
mark it as ready for review in order to actually trigger a CI run.

This idea is found in GitHub's own repos:
* github/codeql-action#2263 (comment)
* https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41
* github/codeql-action#1868
* github/codeql-action#679
webknjaz added a commit to webknjaz/pytest that referenced this pull request Jun 21, 2024
@webknjaz
🧪 Make a draft based plugin bump PR CI trigger
323b0bd 
Normally, PRs/commits published using the default GitHub Actions CI/CD
API token are not propagated to any integrations. This patch marks the
plugin update PR as a draft and leaves a comment asking the maintainers to
mark it as ready for review in order to actually trigger a CI run.

This idea is found in GitHub's own repos:
* github/codeql-action#2263 (comment)
* https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41
* github/codeql-action#1868
* github/codeql-action#679
Glyphack pushed a commit to Glyphack/pytest that referenced this pull request Jul 30, 2024
@webknjaz @Glyphack
🧪 Make a draft based plugin bump PR CI trigger
8819669 
Normally, PRs/commits published using the default GitHub Actions CI/CD
API token are not propagated to any integrations. This patch marks the
plugin update PR as a draft and leaves a comment asking the maintainers to
mark it as ready for review in order to actually trigger a CI run.

This idea is found in GitHub's own repos:
* github/codeql-action#2263 (comment)
* https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41
* github/codeql-action#1868
* github/codeql-action#679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomBolton TomBolton TomBolton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @TomBolton