🧪 Make a draft based plugin bump PR CI trigger #12502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jun 20, 2024
webknjaz
force-pushed
the
maintenance/ci-plugin-update-draft-ux
branch
from
83bf818 to
d03b7f9
Compare
Normally, PRs/commits published using the default GitHub Actions CI/CD API token are not propagated to any integrations. This patch marks the plugin update PR as a draft and leaves a comment asking the maintainers to mark it as ready for review in order to actually trigger a CI run. This idea is found in GitHub's own repos: * github/codeql-action#2263 (comment) * https://github.com/github/codeql-action/blob/4ebadbc7/.github/workflows/update-dependencies.yml#L38-L41 * github/codeql-action#1868 * github/codeql-action#679
webknjaz
force-pushed
the
maintenance/ci-plugin-update-draft-ux
branch
from
d03b7f9 to
072cb52
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
|
@RonnyPfannschmidt this is ready to be auto-merged ^ |
RonnyPfannschmidt
approved these changes
Jun 21, 2024
webknjaz
commented
Jun 25, 2024
| - opened # default | ||
| - synchronize # default | ||
| - reopened # default | ||
| - ready_for_review # used in PRs created from the release workflow |
There was a problem hiding this comment.
Note for the future: the code comment refers to the release workflow, but it's actually update-plugin-list.yml. We need to update the comment at some point.
webknjaz
added
the
type: infrastructure
webknjaz
added a commit
to webknjaz/pytest
that referenced
this pull request
Jul 2, 2024
webknjaz
commented
Jul 2, 2024
| CI runs. From now on, they only need to click the `Ready for review` | ||
| button instead. | ||
|
|
||
| -- by :user:`webknjaz`. |
There was a problem hiding this comment.
Trailing period correction: #12561.
webknjaz
added a commit
that referenced
this pull request
Jul 2, 2024
…02--ci-plugin-update-draft-ux 📝💄 Drop trailing period from #12502 byline
Glyphack
pushed a commit
to Glyphack/pytest
that referenced
this pull request
Jul 30, 2024
Glyphack
pushed a commit
to Glyphack/pytest
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, PRs/commits published using the default GitHub Actions CI/CD API token are not propagated to any integrations. This patch marks the plugin update PR as a draft and leaves a comment asking the maintainers to mark it as ready for review in order to actually trigger a CI run.
This idea is found in GitHub's own repos: