Log commands manually before executing them #1833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bad interaction between #1795 and #1811 which we didn't pick up since the problem only appears when looking at the combination of these two PRs.
In #1811, to make sure we only print the analysis summary once, we invoked the tool runner with
silent: true
to capture CodeQL's stdout without logging it. We then had our stdout listener forward CodeQL's stdout to the Action's stdout. However we missed another implication of settingsilent: true
: this disables the log line which prints the command being invoked. This is because we only started running most of our CodeQL invocations through the tool runner in #1795.With the combination of these two PRs, we stop logging most CodeQL invocations, which reduces the utility of the logs.
This PR starts printing the commands manually to make sure we log them in all cases, including ones where we want to capture the stdout.
Merge / deployment checklist