-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of fatal CLI errors #1795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are losing information about CLI errors in
database {finalize,interpret-results,run-queries}
. When the CLI command includes "A fatal error occurred" in its stderr, we lose other context about the error (such as whether it was an OOM, or out of disk, or something else) in the Actions run summary and in telemetry.Furthermore, the Action is suppressing the improved errors for no code found shipped in CodeQL v2.12.4.
This PR stops suppressing these errors by displaying fatal errors in full, and using the CLI error message for
database finalize
no code found errors for CodeQL CLI v2.12.4 and later. Most of the commits are tweaking the error message to try to improve its utility. In particular, we're quite keen to get it on a single line if we can, as this lets us include all the useful detail we can on the Actions run summary page.Merge / deployment checklist