Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Sorbet RBI files generated/fetched by Tapioca #6143

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Detect Sorbet RBI files generated/fetched by Tapioca #6143

merged 1 commit into from
Nov 1, 2022

Conversation

kivikakk
Copy link
Contributor

Detect Sorbet .rbi files generated by Tapioca's gem introspection/DSL compiler/annotation fetching features.

Description

It's not uncommon for hundreds (or thousands) of generated .rbi files to change following a bundle update or adjustment to a Tapioca DSL compiler. This can clutter the PR view considerably, push real code changes past the threshold of automatically loaded/highlighted diffs, and the nature of generated .rbi is that they aren't amenable to human review.

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

@kivikakk kivikakk requested a review from a team as a code owner October 27, 2022 08:48
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kivikakk 👋 I hope you're well, and glad to see you haven't forgotten about us 😁. Thanks for taking this off my own TODO list 🙇.

@lildude lildude merged commit 16a7a52 into github-linguist:master Nov 1, 2022
@kivikakk kivikakk deleted the tapioca-rbi branch November 2, 2022 07:21
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants