Start generating .gitattributes file for generated and vendored RBI files
#1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `.gitattributes` file to the output folder that marks all RBI files as `generated` for `dsl` and `gem` RBI generation commands. It also add a `.gitattributes` file to the output folder that marks all RBI files as `vendored` for `annotations` command.
paracycle
force-pushed
the
uk-add-gitattributes
branch
from
4fc0dba
to
6f2f432
Compare
Morriar
reviewed
Aug 14, 2023
KaanOzkan
approved these changes
Aug 15, 2023
Morriar
reviewed
Sep 8, 2023
Morriar
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes https://github.com/Shopify/ruby-dev-exp-issues/issues/651
The
linguistgem added support for detecting generated and vendored RBI files in github-linguist/linguist#6143, but it parses the RBI file header comments to understand that, which is quite brittle.Tapioca can do a better job of this, since it already knows that
dslandgemcommands will create "generated" RBI files in the output directory and theannotationscommand will create "vendored" RBI files. So, Tapioca should be generating the appropriate.gitattributesfiles in the relevant output directories to signal that the RBI files contained are generated/vendored.Implementation
GitAttributeshelper module that knows how to create.gitattributesfiles that state the**/*.rbifiles in the folder are either generated or vendored RBI files.DslGenerate,GemGenerate,GemSyncandAnnotationscommands to create appropriate.gitattributesfiles in the output folder.Tests
Added extra test cases for checking generated
.gitattributesfiles.