Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] [pending popularity] add extension nimf for Nim #4327

Closed
wants to merge 1 commit into from

Conversation

timotheecour
Copy link
Contributor

@timotheecour timotheecour commented Nov 14, 2018

/cc @pchaigno

Description

Note 1: the nimf extension (for source code filter Nim files) was previously called tmpl but that was causing confusion because the extension tmpl was too generic and also didn't match the other Nim extensions (nim, nims, nimble, nim.cfg), so nim-lang/Nim#9658 was recently merged to change the tmpl extension to nimf (while retaining backward compatibility); note that currently nimf is only used here: https://github.com/search?q=extension%3Animf+stdtmpl&type=Code ; but the old extension tmpl (which fits the same purpose as nimf) is used in more places, see https://github.com/search?q=extension%3Atmpl+stdtmpl&type=Code ; the plan is to gradually migrate the files using tmpl extension to nimf, and having it supported in linguist will provide extra incentive for the migration (eg syntax highlight), although linguist integration wasn't the only reason for the tmpl=>nimf change.

Note 2: nimf doesn't look like it's being used for anything but Nim source code filters

Checklist:

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage is way too low to add support in Linguist for now. Alternatively, if you think usage will grow to meet our requirement of hundreds of repositories, I can add the extension to #4219. Note that currently, even the usage for .tmpl is too low.

@timotheecour timotheecour changed the title add extension nimf for Nim [TODO] [pending popularity] add extension nimf for Nim Nov 14, 2018
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants