-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extensions for nim files #4295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, is .nimrod
still used?
only old projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I left a few comments inline regarding new extensions and filenames. Could you also add the sample files (including sample files for new filenames) under samples/Nims/
?
For other reviewers, here what I found for extension/filename:
- extension:nimble, 1776 repos, 644 users
- extension:nims defined, 52 files
- filename:nim.cfg, 694 repos, 362 users
- filename:config.nims, 146 files
done
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me.
@timotheecour That's totally fine. |
/cc @pchaigno friendly ping; anything else that needs changing? |
Yes, sorry.
It is mentioned in the contribution guidelines. I'll change the PR template to explicitly mention the directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @timotheecour. I wanted to recheck the usage.
Two comments to address below, but after that, I'd say we're good to merge!
@pchaigno PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your time and contribution @timotheecour!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and welcome to Linguist. Thanks for your contribution.
not sure I'm understanding the result:
|
@timotheecour These changes will only apply once a new release of Linguist is cut. |
what's changing
this fixes https://forum.nim-lang.org/t/4307: syntax highlight of nims, nim.cfg, nimble files broken on github
as reported there, these don't syntax highlight correctly:
Checklist: