Allow crowdfund issues #1597

jvmaia · 2018-07-02T21:32:30Z

Description

Allow the crowd to increase contributions to a bounty, so we can crowdfund issues.

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

urls, views

Testing

I have tested this as the funder and the collaborator.

Refers/Fixes

Fixes: #1380

stickler-ci · 2018-07-02T21:32:59Z

app/assets/v2/js/pages/increase_bounty.js

+      if (document.changePayoutAmount) {
+        $.get('/issue/increase/changepayout/' + amount + '/?pk=' + bountyId + '&network=' + document.web3network)
+          .fail(function(error) {
+            console.log(error);


Unexpected console statement. (no-console)

stickler-ci · 2018-07-02T21:32:59Z

app/retail/emails.py

 from django.utils import timezone
 from django.utils.translation import gettext as _
+from django.urls import reverse


F811 redefinition of unused 'reverse' from line 28

stickler-ci · 2018-07-02T21:32:59Z

app/retail/emails.py

+    print(form_link)
+
+    response_text = '''
+There is someone trying to increase the bounty on {value} on your issue, can you change the payout amount of the bounty? The form to do it: {form_link}. You can increase the payout amount in the value {value}.


E501 line too long (209 > 120 characters)

codecov · 2018-07-02T21:40:52Z

Codecov Report

Merging #1597 into master will decrease coverage by 0.08%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
- Coverage   29.93%   29.85%   -0.09%     
==========================================
  Files         130      130              
  Lines        9596     9678      +82     
  Branches     1243     1247       +4     
==========================================
+ Hits         2873     2889      +16     
- Misses       6619     6685      +66     
  Partials      104      104

Impacted Files	Coverage Δ
app/app/urls.py	`89.74% <ø> (ø)`	⬆️
app/marketing/mails.py	`11.95% <11.11%> (-0.02%)`	⬇️
app/retail/emails.py	`21.1% <33.33%> (+0.24%)`	⬆️
app/dashboard/views.py	`14.43% <6.66%> (-0.19%)`	⬇️
app/retail/views.py	`37.25% <0%> (-1.21%)`	⬇️
app/retail/utils.py	`20% <0%> (-0.39%)`	⬇️
app/dashboard/tokens.py	`100% <0%> (ø)`	⬆️
app/dashboard/utils.py	`26.12% <0%> (+0.21%)`	⬆️
app/dashboard/notifications.py	`16.84% <0%> (+0.32%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d0c91b...6aa7e69. Read the comment docs.

stickler-ci · 2018-07-02T21:41:17Z

app/assets/v2/js/pages/increase_bounty.js

+
+      if (document.changePayoutAmount) {
+        $.get('/issue/increase/changepayout/' + amount + '/?pk=' + bountyId + '&network=' + document.web3network)
+          .fail(function(error) {


Unexpected empty function. (no-empty-function)

stickler-ci · 2018-07-02T21:41:17Z

app/retail/emails.py

+    subject = 'Change payout amount'
+    form_link = reverse('request_change_payout', kwargs={'value': value, 'pk': bounty.id, 'network': bounty.network})
+
+    response_text = "There is someone trying to increase the bounty on {value} on your issue," +


E999 SyntaxError: invalid syntax

stickler-ci · 2018-07-02T21:46:47Z

app/assets/v2/js/pages/increase_bounty.js

@@ -111,6 +111,10 @@ $(document).ready(function() {
        mixpanel.track('Submit New Bounty Success', {});
        document.location.href = '/funding/details/?url=' + issueURL;
      }, 1000);
+
+      if (document.changePayoutAmount) {
+        $.get('/issue/increase/changepayout/' + amount + '/?pk=' + bountyId + '&network=' + document.web3network)


Missing semicolon. (semi)

stickler-ci · 2018-07-02T21:46:48Z

app/retail/emails.py

@@ -588,6 +589,16 @@ def render_new_bounty_roundup(to_email):
    return response_html, response_txt, subject


+def render_change_payout_amount(bounty, value):
+    subject = 'Change payout amount'
+    form_link = reverse('request_change_payout', kwargs={'value': value, 'pk': bounty.id, 'network': bounty.network})


F841 local variable 'form_link' is assigned to but never used

jvmaia · 2018-07-02T21:50:21Z

Does the stickler-ci verify when a variable is used inside a f-string?

owocki · 2018-07-03T00:59:13Z

i keep getting crazy high gas fees when i try to use this feature ( screenshot : http://bits.owocki.com/2T1M3e2r3Q3v/Screen%20Shot%202018-07-02%20at%205.58.38%20PM.png )

Usually that means theres a smart contract error on thetx i'm about to submit

jvmaia · 2018-07-03T01:08:32Z

Ook, I'll try to remove the if/else statement inside do_bounty function and separate it into 3 different functions.

jvmaia · 2018-07-03T01:43:07Z

Hey, I didn't got this error here, weird. But I'll make the change because it's more readable.

owocki · 2018-07-03T15:19:51Z

Hey, I didn't got this error here, weird. But I'll make the change because it's more readable.

Here are the reproduction steps for the issue.

In a browser:

Create a new bounty

In another browser with different metamask seed:

Open the bounty you created.
Click 'Add contribution'.
Submit the 'increase funding form'
Metamask error appears.

owocki · 2018-07-03T15:23:18Z

app/assets/v2/js/pages/bounty_details.js

@@ -662,9 +661,8 @@ var do_actions = function(result) {
    }

    if (show_increase_bounty) {


won't you need to update show_increase_bounty too?

Is it needed? what I change here is the argument from enabled = increase_bounty_enabled; to enabled = true;, the show_increase_bounty is fine.

owocki · 2018-07-03T15:25:33Z

debugging further, it seems to call do_bounty_as_funder_increasingPayout even when i am not the funder

owocki · 2018-07-03T15:32:06Z

when there is no contract error, i get a very high gas price

owocki · 2018-07-03T15:33:16Z

9dc7a12 should fix the issues with is_funder

owocki · 2018-07-03T15:34:10Z

I'm still seeing contract errors when I try to use the flow though. I think this just needs to be testeded end to end in each of these scenarios:

    if (document.isFunder) {
      if (document.changePayoutAmount) {
        do_bounty_as_funder_increasingPayout();
      } else {
        do_bounty_as_funder_changingFulfillment();
      }
    } else {
      do_bounty_as_contributor();
    }

jvmaia · 2018-07-03T23:01:05Z

thanks for the fixes, sorry for the delay, I'll test it now!

jvmaia · 2018-07-04T02:36:52Z

Here are the reproduction steps for the issue.

ook, I did it exactly as you described, but the error does not appears to me. I'm using firefox quantum to submit the 'increase funding form' as the contributor. screenshot: https://i.imgur.com/Lj7Ix9L.png

jvmaia · 2018-07-04T02:50:47Z

my next commits fix the variable document.changePayoutAmount and the if/else to decide which function call.

jvmaia · 2018-07-04T02:53:49Z

the error appears only when the do_bounty_as_funder_changingFulfillment is called, I'll dig into it tomorrow.

jvmaia · 2018-07-05T03:31:55Z

Ook, I find the problem, the contract.changeBountyFulfillment requires the issue is at stage Draft (doc link), and the contract.issueAndActivateBounty, used to create the bounty, set the issue's stage to Active (doc link).

owocki · 2018-07-06T20:47:24Z

oh shoot.. i guess that means that we can't do this after all... ? @jvmaia thats my fault, i can still pay out

@mbeylin any workarounds for #1597 (comment) you can think of ?

owocki · 2018-07-08T21:35:55Z

very sorry we could not merge this..

@mbeylin let us know if you see any potential workarounds for 1.0.. this is a highly requested feature from our community

owocki · 2018-07-09T00:36:08Z

unfortunately it looks liek transitionToState() is an internal only method right now

jvmaia · 2018-07-09T03:16:11Z

ooh sorry @owocki, it would be a pleasure to work on the workaround to this.

jvmaia added 5 commits July 2, 2018 17:36

allow crowdfund issues

9338faf

allow crowdfund issues

9082e33

fix lint

9b22161

run automatic linter

4ea1a4c

remove duplicated import

e1f7cf1

stickler-ci reviewed Jul 2, 2018

View reviewed changes

fix lint

b2fe984

stickler-ci reviewed Jul 2, 2018

View reviewed changes

fix lint[2]

4822cc4

stickler-ci reviewed Jul 2, 2018

View reviewed changes

add semicolon

7e311ff

gitcoinbot mentioned this pull request Jul 2, 2018

As a funder, I want to allow the crowd to increase contributions to a bounty, so we can crowdfund issues. #1380

Closed

improve do_bounty function

6b59bb3

owocki reviewed Jul 3, 2018

View reviewed changes

fixes issue with is_funder and change_payout_amount

9dc7a12

ghost assigned owocki Jul 3, 2018

ghost added the in progress label Jul 3, 2018

fix document.changePayoutAmount & do_bounty calls

98016f7

fix email notification

6aa7e69

owocki closed this Jul 13, 2018

ghost removed the in progress label Jul 13, 2018

owocki mentioned this pull request Jul 26, 2018

crowdfunding v2 #1832

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow crowdfund issues #1597

Allow crowdfund issues #1597

jvmaia commented Jul 2, 2018

stickler-ci Jul 2, 2018

stickler-ci Jul 2, 2018

stickler-ci Jul 2, 2018

codecov bot commented Jul 2, 2018 •

edited

Loading

stickler-ci Jul 2, 2018

stickler-ci Jul 2, 2018

stickler-ci Jul 2, 2018

stickler-ci Jul 2, 2018

jvmaia commented Jul 2, 2018

owocki commented Jul 3, 2018

jvmaia commented Jul 3, 2018

jvmaia commented Jul 3, 2018

owocki commented Jul 3, 2018

owocki Jul 3, 2018

jvmaia Jul 4, 2018

owocki commented Jul 3, 2018

owocki commented Jul 3, 2018

owocki commented Jul 3, 2018

owocki commented Jul 3, 2018

jvmaia commented Jul 3, 2018

jvmaia commented Jul 4, 2018 •

edited

Loading

jvmaia commented Jul 4, 2018

jvmaia commented Jul 4, 2018

jvmaia commented Jul 5, 2018

owocki commented Jul 6, 2018

owocki commented Jul 8, 2018

owocki commented Jul 9, 2018

jvmaia commented Jul 9, 2018

		@@ -662,9 +661,8 @@ var do_actions = function(result) {
		}

		if (show_increase_bounty) {

Allow crowdfund issues #1597

Allow crowdfund issues #1597

Conversation

jvmaia commented Jul 2, 2018

Description

Checklist

Affected core subsystem(s)

Testing

Refers/Fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 2, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jvmaia commented Jul 2, 2018

owocki commented Jul 3, 2018

jvmaia commented Jul 3, 2018

jvmaia commented Jul 3, 2018

owocki commented Jul 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Jul 3, 2018

owocki commented Jul 3, 2018

owocki commented Jul 3, 2018

owocki commented Jul 3, 2018

jvmaia commented Jul 3, 2018

jvmaia commented Jul 4, 2018 • edited Loading

jvmaia commented Jul 4, 2018

jvmaia commented Jul 4, 2018

jvmaia commented Jul 5, 2018

owocki commented Jul 6, 2018

owocki commented Jul 8, 2018

owocki commented Jul 9, 2018

jvmaia commented Jul 9, 2018

codecov bot commented Jul 2, 2018 •

edited

Loading

jvmaia commented Jul 4, 2018 •

edited

Loading