Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a funder, I want to allow the crowd to increase contributions to a bounty, so we can crowdfund issues. #1380

Closed
owocki opened this issue Jun 5, 2018 · 17 comments

Comments

@owocki
Copy link
Contributor

owocki commented Jun 5, 2018

User Story

As a funder, I want to allow the crowd to increase contributions to a bounty, so we can crowdfund issues.

Why Is this Needed?

Summary:
Crowdfunding is powerful.

Description

Type:
Feature

Current Behavior

No crowdfunding allowed

Expected Behavior

Crowdfunding allowed

Solution

Summary:

  • the 'Add Contribution' button is shown to everyone on each bounty
  • the 'add contribution' form is kept the same, but if someone other than the bounty hunter access it, the following changes are made
  1. the form calls contribute() doc link instead of increasePayout doc link
  2. the system emails the funder asking them to change the payout amount of the bounty with a link to this form
  • if the person who accesses the 'add contribution' form is the funder, neither of these actions happen

Definition of Done

See above

Additional Information

Docuemntation on this : Bounties-Network/StandardBounties#40

@darkdarkdragon
Copy link
Contributor

@owocki why it is blocked by #1379 ?

@owocki
Copy link
Contributor Author

owocki commented Jun 11, 2018

ur right, its not

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Jul 1, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 20 hours ago. Please review their questions below:

  1. jvmaia has started work.
  • Q: I'll read the code and start to work on it or ask about anything I have a doubt on

@jvmaia
Copy link
Contributor

jvmaia commented Jul 2, 2018

I'm getting problem to identify what is the form that will be sent to the funder change the payout amount, it's the last part lacking to solve the issue, I guess.

@owocki
Copy link
Contributor Author

owocki commented Jul 2, 2018

hey @jvmaia -- https://faucet.rinkeby.io/ is a good place to get rinkeby ETH

I'm getting problem to identify what is the form that will be sent to the funder change the payout amount, it's the last part lacking to solve the issue, I guess.

youll want to call changeBountyFulfillmentAmount()

@owocki
Copy link
Contributor Author

owocki commented Jul 2, 2018

right @mbeylin ?

@jvmaia
Copy link
Contributor

jvmaia commented Jul 2, 2018

hey @jvmaia -- https://faucet.rinkeby.io/ is a good place to get rinkeby ETH

I found it, thanks =)

@jvmaia
Copy link
Contributor

jvmaia commented Jul 2, 2018

Is there a template to use in the email or I can just send a text?

There is someone trying to increase the bounty on your issue, can you change the payout amount of the bounty? The form to do it: [form_link]

Would the text be something like this?

@owocki
Copy link
Contributor Author

owocki commented Jul 2, 2018

yes!

@jvmaia
Copy link
Contributor

jvmaia commented Jul 2, 2018

I'm thinking about use the increase_bounty form to the funder change the payout amount, just need to add a get variable like issue/increase?pk=X&network=rinkeby&CHANGE_PAYOUT=true, then I will just need to modify the do_bounty function in the increase_bounty.js. Is it correct?

@owocki
Copy link
Contributor Author

owocki commented Jul 2, 2018

seems smart to me

@jvmaia jvmaia mentioned this issue Jul 2, 2018
3 tasks
@jvmaia
Copy link
Contributor

jvmaia commented Jul 2, 2018

submitting the work on gitcoin, eth network congested.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 200.0 DAI (200.0 USD @ $1.0/DAI) has been submitted by:

  1. @jvmaia

@owocki please take a look at the submitted work:


@PixelantDesign
Copy link
Contributor

@owocki has this been paid out? ok to close this?

@owocki
Copy link
Contributor Author

owocki commented Jul 8, 2018

paying out now

@owocki owocki closed this as completed Jul 8, 2018
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @jvmaia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants