critical: 2.10.2.windows.1: git-gui crashes when opening a 3rd window #1014
Comments
Could you be more specific how it crashes (e.g. how can you tell that Git GUI is not simply refusing to do stuff because it does not find any associated repository)? |
|
Your are right.. I do not know if it is really git-gui that crashes... but here the pop up window
|
|
Update... the Wish application crashes when opening a new repository not in the list of open recent repositories and the list contains 10 repo. |
zosrothko
changed the title
|
This issue is critical since there is no way to flush the list.... |
|
look at my old series http://public-inbox.org/git/[email protected]/ I can't remember if this was merged. |
|
@zosrothko, It looks like the series never got near the Git 'pu' branch. The series should also go to Pat Thoyts who maintains the git-gui https://github.com/git-for-windows/git/blob/master/Documentation/SubmittingPatches#L325-L327 If you can review Junio's comments from the V2 series that would be a help. i.e. provide some feedback - this is open source, so your help is needed. Philip |
|
Also, can you share the git-gui entries in your .gitconfig (just show the first ~5 chars of the path..). Try My gui section (from the above, without the --show-origin) looks like: Do you have share (//) paths? Are the all absolute drive paths? |
|
@zosrothko I agree with @PhilipOakley: your assistance is required to push the resolution forward. |
|
Here the result: |
@zosrothko by "your assistance is required" I was more referring to offering a review of @PhilipOakley's patches, as well as actually testing whether they fix your issue. |
|
@zosrothko Thanks for that output. It at least confirms that it isn't at all related to the If you are able to pick up and apply those patches direct (*) to the Tcl/Tk shell script, and then check that they work for you that would be a great assistance as @dscho mentioned. (*) If you have the full git reo and SDK then all the better. Though as the gui is a simple shel script you could bypass all that by using a local tool to apply those diffs directly! |
|
@zosrothko As a workaround, you can go to the text file file: |
|
The branch with my 4 patches is https://github.com/PhilipOakley/git/tree/dup-gui They are not the best (in retrospect) as they work through the fault/fix sequence of incremental improvement, rather than identifying and resolving all the issues as a clean sequence. Aside - @zosrothko - are all those repositories still in existance at those specific paths from your machine at the point that the gui is started? |
|
I applied the 4 patches of @PhilipOakley and the issue is solved at least at first glance... Thanks for your help on this issue, but I think your patches should be applied to the main stream to avoid the same situation when moving to the 2.11 version. I let you close this issue or not if you want to keep it as a reminder. |
|
zosrothko
your oathes should be applied to the main
s/oathes/patches/ I presume, 😉
I guess that was a spell checker thinking too hard.
I do hope to update the commit messages and re-submit some updated patches in the next few days, time permitting.
Were you able to confirm any of the other questions (should they come up in the upstream code review)?
Philip
|
|
@PhilipOakley |
|
@zosrothko - another clarification - did you try the "debugger"/'debogeur' button (as per your screen shot #1014 (comment) above) to get any more information? I'm trying to work out all the different corner cases, and make sure that they weren't reported as 'solved' previously (which would mean I need to explain what went wrong). e.g. git@3c6a2870274ea629499dfb6a9 git@24f7c64. (Tcl/Tk isn't that easy to get my head around..) |
|
@PhilipOakley After your patches be applied, the Wish application does not crash anymore, thus the corresponding issue can be closed. Thanks |
|
@zosrothko thank you for testing! You probably think this a little thing, but it does help incredibly. @PhilipOakley let's get these patches into Git GUI: master...PhilipOakley:dup-gui AFAIU, the proper way is to rebase the patches to https://github.com/patthoyts/git-gui and open a PR there. I rebased your patches using git -C /path/to/git format-patch -4 --stdout PhilipOakley/dup-gui | git am -3 -p2in my clone of Please note that it looks as if @patthoyts is super busy with too many things, so it may be a while before he gets to the PR. In that case, I would like to merge your patches into Git for Windows early (and I would update them in case any changes are required by upstream Git/Git GUI). |
|
@dscho I'm cautious that there are other issues buried in that code that I haven't bottomed out, for instance the procedure Then there are the cases where the recent repo list is updated in the config, but the internal list isn't updated (various for loops). |
I sent an explanation as a reply to your mail: the call is inside another proc, so all is well. |
|
@dscho Thanks for the explanation - that Tcl stuff can be tricky ;-) The format-patch innvocation is useful! There is still one, maybe two points still to resolve. First was trying to get a plausible reason that folks either get duplicate config entries, or the max limit gets busted, but that could be put aside as just a worry, not an issue. The second is that if the I think that I can simply check the size of the sorted_recent list agains the maxrecent and adjust the display size to suit (between #L137-138). As an aside there are two identical places (#L28, #L272 that does Which suggests that it could be a |
|
@PhilipOakley sounds like you are almost ready to open that PR 😄 |
|
@PhilipOakley sounds like you are almost ready to open that PR
I'm failing on testing the git gui in its stand-alone repo "C:\git-sdk-32\usr\src\git-gui" when run from the regular SDK git bash (NOT integrated with cmd ;-).
I've run 'make', and had it start directly into the commit viewer, but haven't sorted out how to make it give the options screen. I've also tried from C:\git-sdk-32\usr\src and tried ./git-gui/git-gui.sh
Looks like I'll also have to apply the patches to the regular git/git-gui/ to somehow get the GfW correct startup.
My patches (against Pat's git-gui repo) are at: https://github.com/PhilipOakley/git-gui/tree/dup-gui
I especially want to test the last patch update.
Philip
|
|
At the moment I've totally failed to test the updates. I've tried various different I think it is that the mods are to parts that are pre-compiled into a lib ("C:\git-sdk-32\mingw32\share\git-gui\lib\choose_repository.tcl") and I'm not sure where to look for the code that compiles that. |
|
@PhilipOakley this works here: |
|
@PhilipOakley this works here: GIT_GUI_LIB_DIR=$PWD/lib ./git-gui
Thanks that has helped. It didn't quite work directly, but the
GIT_GUI_LIB_DIR clue was the key.
To do my tests it can't be run in a repo directory, as it would simply start
in that repo. It needed to be started from else where. The other bit is I
needed to call the .sh version.
```
Philip@PhilipOakley MINGW32 /usr/src
$ GIT_GUI_LIB_DIR=$PWD/git/gitgui/lib ./git/git-gui/git-gui.sh
```
I have caught a final bug in the routine that limits the list to the
`gui.maxrecentrepo` value - I needed to add a `catch` into the `--unset-all`
so that the second time around it didn't fail quietly.
I need to update my branch, push it, double check I have it right, then
raise the golden PR!
…--
Philip
|
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue git-for-windows/git#1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue git-for-windows#1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue git-for-windows#1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue git-for-windows#1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
The git gui's recent repo list may become contaminated with duplicate entries. The git gui would barf when attempting to remove one entry. Remove them all - there is no option within 'git config' to selectively remove one of the entries. This issue was reported on the 'Git User' list (https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc, Warning: gui.recentrepo has multiply values while executing). And also by zosrothko as a Git-for-Windows issue #1014. On startup the gui checks that entries in the recentrepo list are still valid repos and deletes thoses that are not. If duplicate entries are present the 'git config --unset' will barf and this prevents the gui from starting. Subsequent patches fix other parts of recentrepo logic used for syncing internal lists with the external .gitconfig. Reported-by: Alexey Astakhov <[email protected]> Signed-off-by: Philip Oakley <[email protected]>
Setup
defaults?
to the issue you're seeing?
TODO
Details
cmd.exe
Minimal, Complete, and Verifiable example
this will help us understand the issue.
The text was updated successfully, but these errors were encountered: