Skip to content

Commit

Permalink
git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
Browse files Browse the repository at this point in the history
The git gui's recent repo list may become contaminated with duplicate
entries. The git gui would barf when attempting to remove one entry.
Remove them all - there is no option within 'git config' to selectively
remove one of the entries.

This issue was reported on the 'Git User' list
(https://groups.google.com/forum/#!topic/git-users/msev4KsQGFc,
Warning: gui.recentrepo has multiply values while executing).

And also by zosrothko as a Git-for-Windows issue
#1014.

On startup the gui checks that entries in the recentrepo list are still
valid repos and deletes thoses that are not. If duplicate entries are
present the 'git config --unset' will barf and this prevents the gui
from starting.

Subsequent patches fix other parts of recentrepo logic used for syncing
internal lists with the external .gitconfig.

Reported-by: Alexey Astakhov <[email protected]>
Signed-off-by: Philip Oakley <[email protected]>
  • Loading branch information
Philip Oakley authored and Git for Windows Build Agent committed Aug 10, 2017
1 parent 438b969 commit 80257a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git-gui/lib/choose_repository.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ proc _get_recentrepos {} {

proc _unset_recentrepo {p} {
regsub -all -- {([()\[\]{}\.^$+*?\\])} $p {\\\1} p
git config --global --unset gui.recentrepo "^$p\$"
git config --global --unset-all gui.recentrepo "^$p\$"
load_config 1
}

Expand Down

0 comments on commit 80257a3

Please sign in to comment.