Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inhibit prometheus-agent alerts when a cluster has no worker nodes #1395

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Inhibit prometheus-agent alerts when a cluster has no worker nodes #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddc0a01
Inhibit prometheas-agent alerts when a cluster has no worker nodes
hervenicol Oct 15, 2024
c824ee3
--amend
hervenicol Oct 15, 2024
584ccfe
--amend
hervenicol Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Modify `KyvernoWebhookHasNoAvailableReplicas` to check specifically for Kyverno resource webhook.
- Inhibit prometheas-agent alerts when a cluster has no worker nodes (AWS vintage only for now)

## [4.19.0] - 2024-10-15

Expand Down
1 change: 1 addition & 0 deletions helm/prometheus-rules/templates/platform/atlas/alerting-rules/prometheus-agent.rules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ spec:
cancel_if_cluster_is_not_running_prometheus_agent: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
cancel_if_cluster_has_no_workers: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This inhibition exists in the alertmanager config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does. Do you have reasons to doubt it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all :) I know we have a lot of "inhibitions" configured that are not used there so I was wondering :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're looking for evidence, it's here:
https://github.com/giantswarm/prometheus-meta-operator/blob/main/files/templates/alertmanager/alertmanager.yaml#L612

## Same as PrometheusAgentFailing, but triggers inhibition earlier and does not page.
- alert: PrometheusAgentFailingInhibition
annotations:
Expand Down
2 changes: 2 additions & 0 deletions ...s/providers/capi/capa-mimir/platform/atlas/alerting-rules/prometheus-agent.rules.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ tests:
team: atlas
topic: observability
inhibit_prometheus_agent_down: "true"
cancel_if_cluster_has_no_workers: "true"
cancel_if_cluster_is_not_running_prometheus_agent: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
Expand Down Expand Up @@ -78,6 +79,7 @@ tests:
topic: observability
inhibit_prometheus_agent_down: "true"
installation: myinstall
cancel_if_cluster_has_no_workers: "true"
cancel_if_cluster_is_not_running_prometheus_agent: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
Expand Down
2 changes: 2 additions & 0 deletions test/tests/providers/capi/capa/platform/atlas/alerting-rules/prometheus-agent.rules.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ tests:
topic: observability
inhibit_prometheus_agent_down: "true"
instance: prometheus-agent
cancel_if_cluster_has_no_workers: "true"
cancel_if_cluster_is_not_running_prometheus_agent: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
Expand Down Expand Up @@ -61,6 +62,7 @@ tests:
inhibit_prometheus_agent_down: "true"
installation: myinstall
instance: prometheus-agent
cancel_if_cluster_has_no_workers: "true"
cancel_if_cluster_is_not_running_prometheus_agent: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
Expand Down
2 changes: 2 additions & 0 deletions test/tests/providers/capi/capz/platform/atlas/alerting-rules/prometheus-agent.rules.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ tests:
topic: observability
inhibit_prometheus_agent_down: "true"
instance: prometheus-agent
cancel_if_cluster_has_no_workers: "true"
cancel_if_cluster_is_not_running_prometheus_agent: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
Expand Down Expand Up @@ -61,6 +62,7 @@ tests:
inhibit_prometheus_agent_down: "true"
installation: myinstall
instance: prometheus-agent
cancel_if_cluster_has_no_workers: "true"
cancel_if_cluster_is_not_running_prometheus_agent: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
Expand Down
2 changes: 2 additions & 0 deletions ...tests/providers/vintage/aws/platform/atlas/alerting-rules/prometheus-agent.rules.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ tests:
topic: observability
inhibit_prometheus_agent_down: "true"
instance: prometheus-agent
cancel_if_cluster_has_no_workers: "true"
cancel_if_cluster_is_not_running_prometheus_agent: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
Expand Down Expand Up @@ -61,6 +62,7 @@ tests:
inhibit_prometheus_agent_down: "true"
installation: myinstall
instance: prometheus-agent
cancel_if_cluster_has_no_workers: "true"
cancel_if_cluster_is_not_running_prometheus_agent: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
Expand Down