Inhibit prometheus-agent alerts when a cluster has no worker nodes #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,6 +51,7 @@ spec: | |||
| cancel_if_cluster_is_not_running_prometheus_agent: "true" | |||
| cancel_if_cluster_status_creating: "true" | |||
| cancel_if_cluster_status_deleting: "true" | |||
| cancel_if_cluster_has_no_workers: "true" | |||
There was a problem hiding this comment.
This inhibition exists in the alertmanager config?
There was a problem hiding this comment.
Yes it does. Do you have reasons to doubt it?
There was a problem hiding this comment.
Not at all :) I know we have a lot of "inhibitions" configured that are not used there so I was wondering :)
There was a problem hiding this comment.
If you're looking for evidence, it's here:
https://github.com/giantswarm/prometheus-meta-operator/blob/main/files/templates/alertmanager/alertmanager.yaml#L612
hervenicol
changed the title
hervenicol
force-pushed
the
aws-inhibit-noworker-clusters
branch
from
ea3bdcc to
584ccfe
Compare
QuentinBisson
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/31390
This PR prevents prometheus-agent alerts to fire when the WC has no worker nodes.
But the inhibition alert only works for AWS vintage for now.
Checklist
oncall-kaas-cloudGitHub group).